HomeFreeBSD

Illumos #2671: zpool import should not fail if vdev ashift has increased

Description

Illumos #2671: zpool import should not fail if vdev ashift has increased

Reviewed by: Adam Leventhal <ahl@delphix.com>
Reviewed by: Eric Schrock <eric.schrock@delphix.com>
Reviewed by: Richard Elling <richard.elling@richardelling.com>
Reviewed by: Gordon Ross <gwr@nexenta.com>
Reviewed by: Garrett D'Amore <garrett@damore.org>
Approved by: Richard Lowe <richlowe@richlowe.net>

Refererces to Illumos issue:

https://www.illumos.org/issues/2671

This patch has been slightly modified from the upstream Illumos
version. In the upstream implementation a warning message is
logged to the console. To prevent pointless console noise this
notification is now posted as a "ereport.fs.zfs.vdev.bad_ashift"
event.

The event indicates a non-optimial (but entirely safe) ashift
value was used to create the pool. Depending on your workload
this may impact pool performance. Unfortunately, the only way
to correct the issue is to recreate the pool with a new ashift.

NOTE: The unrelated fix to the comment in zpool_main.c appears in the upstream commit and was preserved for consistnecy.

Ported-by: Cyril Plisko <cyril.plisko@mountall.com>
Reworked-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #955

Details

Provenance
George Wilson <gwilson@delphix.com>Authored on May 3 2012, 12:49 PM
Brian Behlendorf <behlendorf1@llnl.gov>Committed on Nov 15 2012, 7:05 PM
Parents
rG3997bc74351d: zfs-0.6.0-rc12
Branches
Unknown
Tags
Unknown

Event Timeline

Brian Behlendorf <behlendorf1@llnl.gov> committed rG32a9872bbae9: Illumos #2671: zpool import should not fail if vdev ashift has increased (authored by George Wilson <gwilson@delphix.com>).Nov 15 2012, 7:05 PM