HomeFreeBSD

ZTS: test-runner: always apply timestamp to outputdir before updating

Description

ZTS: test-runner: always apply timestamp to outputdir before updating

The default outputdir had a timestamp appended in TestRun.init, and
then the timestamp was unconditionally applied again after the runfile
had been loaded, assuming that an outputdir would be set in the runfile
too. If the runfile didn't have an outputdir, then the outputdir would
get a second timestamp appended.

Further, if test groups or individual tests themselves specificed an
outputdir, those would be set on their config, but would not get a
timestamp appended. It's not entirely clear if that's wrong or not, but
it is certainly not consistent with the rest.

To clean all this up, change things to append a timestamp to a received
outputdir (from arg or runfile) before setting it in any TestRun,
TestGroup or Test object.

Sponsored-by: https://despairlabs.com/sponsor/
Signed-off-by: Rob Norris <robn@despairlabs.com>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de>
Reviewed-by: Igor Kozhukhov <igor@dilos.org>

Details

Provenance
rob.norris_klarasystems.comAuthored on Feb 14 2025, 11:23 PM
Tony Hutter <hutter2@llnl.gov>Committed on Thu, Feb 27, 10:39 PM
Parents
rG4581c4fcbe31: ZTS: runfiles: remove explicit outputdir
Branches
Unknown
Tags
Unknown