HomeFreeBSD

ICMP checksum test: Fix for big endian

Description

ICMP checksum test: Fix for big endian

The in_cksum tests originally tried to simulate a BE environment by
swapping the byte order of the input. But that's overcomplicated, and
didn't actually work on real BE hardware. The correct testing strategy
is just to test on the native endianness, and run the tests in both BE
and LE environments.

Submitted by: Renato Riolino <renato.riolino@eldorado.org.br>
Reviewed By: asomers
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D23193

Details

Provenance
renato.riolino_eldorado.org.brAuthored on Jan 12 2021, 1:56 AM
asomersCommitted on Jan 12 2021, 2:03 AM
Reviewer
asomers
Differential Revision
D23193: ICMP checksum test: Fix for big endian
Parents
rG7eaea04a5bb1: amd64: compare TLB shootdown target to all_cpus
Branches
Unknown
Tags
Unknown