HomeFreeBSD

libuutil: deobfuscate internal pointers

Description

libuutil: deobfuscate internal pointers

uu_avl and uu_list stored internal next/prev pointers and parent
pointers (unused) obfuscated (byte swapped) to hide them from a long
forgotten leak checker (No one at the 2022 OpenZFS developers meeting
could recall the history.) This would break on CHERI systems and adds
no obvious value. Rename the members, use proper types rather than
uintptr_t, and eliminate the related macros.

Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brooks Davis <brooks.davis@sri.com>
Closes #14126

Details

Provenance
brooksAuthored on Nov 3 2022, 4:57 PM
GitHub <noreply@github.com>Committed on Nov 3 2022, 4:57 PM
Parents
rG211ec1b9fde3: Deny receiving into encrypted datasets if the keys are not loaded
Branches
Unknown
Tags
Unknown