HomeFreeBSD

ice(4): properly use kernel option RSS

Description

ice(4): properly use kernel option RSS

Header ice_rss.h uses the kernel RSS interface if option RSS is defined.
However when ice_rss.h is included by ice_lib.h there is no prior
inclusion of ice_opts.h to set RSS causing ifdef RSS to always fail. Add
ice_opts.h to the top of ice_lib.h (like ice_iflib.h) so RSS can be
defined when ice_rss.h is parsed.

With that in place, compilation fails due to a missing defintion of
ICE_DEFAULT_RSS_HASH_CONFIG. It is defined in ice_rss.h only when RSS is
not defined. Since this define is not part of the kernel RSS interface
but ice-specific, it should always be defined. Move its definition
outside of ifdef RSS.

PR: 255309
Reviewed by: mhorne, erj (earlier version)
MFC after: 3 days
Pull Request: https://github.com/freebsd/freebsd-src/pull/1460

(cherry picked from commit 6e5650896fe47398e49e3d81af60cc60dbb09e6e)

Details

Provenance
Brian Poole <brian90013@gmail.com>Authored on Oct 11 2024, 7:57 PM
mhorneCommitted on Wed, Nov 13, 3:47 PM
Parents
rGddc9bb706808: usb: fix loop in usb_config_parse
Branches
Unknown
Tags
Unknown

Event Timeline