HomeFreeBSD

zio_dva_throttle_done() should allow zinjected ZIO

Description

zio_dva_throttle_done() should allow zinjected ZIO

If fault injection is enabled, the ZIO_FLAG_IO_RETRY could be set by
zio_handle_device_injection() to generate the FMA events and update
stats. Hence, ignore the flag and process such zios.

A better fix would be to add another flag in the zio_t to indicate that
the zio is failed because of a zinject rule. However, considering the
fact that we do this in debug bits, we could do with the crude check
using the global flag zio_injection_enabled which is set to 1 when
zinject records are added.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Sanjeev Bagewadi <sanjeev.bagewadi@gmail.com>
Closes #6383
Closes #6384

Details

Provenance
sanjeevbagewadi <sanjeev.bagewadi@gmail.com>Authored on Aug 10 2017, 10:53 PM
Brian Behlendorf <behlendorf1@llnl.gov>Committed on Aug 10 2017, 10:53 PM
Parents
rGb58237e769a4: Man page fixes
Branches
Unknown
Tags
Unknown

Event Timeline

Brian Behlendorf <behlendorf1@llnl.gov> committed rG21df134f4cb1: zio_dva_throttle_done() should allow zinjected ZIO (authored by sanjeevbagewadi <sanjeev.bagewadi@gmail.com>).Aug 10 2017, 10:53 PM