HomeFreeBSD

Silence unused-but-set-variable warnings

Description

Silence unused-but-set-variable warnings

Clang 13.0.0 added support for Wunused-but-set-parameter and
-Wunused-but-set-variable which correctly detects two unused
variables in zstd resulting in a build failure. This commit
annotates these instances accordingly.

  https://releases.llvm.org/13.0.1/tools/clang/docs/ReleaseNotes.html#id6

In FSE_createCTable(), malloc() is intentionally defined as NULL when
compiled in the kernel so the variable is unused.

  zstd/lib/compress/fse_compress.c:307:12: error: variable 'size'
  set but not used [-Werror,-Wunused-but-set-variable]

Additionally, in ZSTD_seqDecompressedSize() the assert is compiled
out similarly resulting in an unused variable.

  zstd/lib/compress/zstd_compress_superblock.c:412:12: error: variable
  'litLengthSum' set but not used [-Werror,-Wunused-but-set-variable]

Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #13382

Details

Provenance
Brian Behlendorf <behlendorf1@llnl.gov>Authored on Apr 29 2022, 9:21 PM
GitHub <noreply@github.com>Committed on Apr 29 2022, 9:21 PM
Parents
rGf2330bd15684: Default zfs_max_recordsize to 16M
Branches
Unknown
Tags
Unknown

Event Timeline

GitHub <noreply@github.com> committed rG1bf3abc6343b: Silence unused-but-set-variable warnings (authored by Brian Behlendorf <behlendorf1@llnl.gov>).Apr 29 2022, 9:21 PM