HomeFreeBSD

virtio_mmio: Negotiate the upper half of the feature bits too

Description

virtio_mmio: Negotiate the upper half of the feature bits too

The feature bits are exposed as a 32-bit register with 2 banks, so we
should negotiate both halves. Notably, VIRTIO_F_VERSION_1 is in the
upper half, and will be used in an upcoming commit.

The PCI bus driver also has this bug, but the legacy BAR layout did not
include selector registers and is rather different from the modern
layout, so it remains solely as legacy.

Reviewed by: br, brooks (mentor), jhb (mentor)
Approved by: br, brooks (mentor), jhb (mentor)
Differential Revision: https://reviews.freebsd.org/D25131

Details

Provenance
jrtc27Authored on Jun 8 2020, 9:49 PM
Parents
rG19870105e1ec: Use Fl instead of Ar for long flags
Branches
Unknown
Tags
Unknown

Event Timeline