HomeFreeBSD

ZIL claiming should not start user accounting

Description

ZIL claiming should not start user accounting

Currently, ZIL claiming dirties objsets which causes
dsl_pool_sync() to attempt to perform user accounting on
them. This causes problems for encrypted datasets that were
raw received before the system went offline since they
cannot perform user accounting until they have their keys
loaded. This triggers an ASSERT in zio_encrypt(). Since
encryption was added, the code now depends on the fact that
data should only be written when objsets are owned. This
patch adds a check in dmu_objset_do_userquota_updates()
to ensure that useraccounting is only done when the objsets
are actually owned for write. As part of this work, the
zfsvfs and zvol code was updated so that it no longer lies
about owning objsets readonly.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tom Caputi <tcaputi@datto.com>
Closes #6916
Closes #7163

Details

Provenance
Tom Caputi <tcaputi@datto.com>Authored on Feb 21 2018, 12:27 AM
Brian Behlendorf <behlendorf1@llnl.gov>Committed on Feb 21 2018, 12:27 AM
Parents
rGcbce58135341: Fix coverity defects: zfs channel programs
Branches
Unknown
Tags
Unknown

Event Timeline

Brian Behlendorf <behlendorf1@llnl.gov> committed rG163a8c28dd70: ZIL claiming should not start user accounting (authored by Tom Caputi <tcaputi@datto.com>).Feb 21 2018, 12:27 AM