HomeFreeBSD

Multiple dracut module install script cleanups

Description

Multiple dracut module install script cleanups

  • Replaced intances of dracut_install with inst_simple
  • Removed calls to test -x mark_hostonly because the function is an

inbuilt dracut function

  • Removed redundant installation of systemd-ask-password and

systemd-tty-ask-password-agent because they are already installed by
the systemd module. There is no need to install them again

  • Removed multiple calls to the mark_hostonly function because the

inst_simple has a command-line switch for it

  • Cleaned up the installation of the zpool.cache, vdev_id.conf and

hostid files to make the logic easier to follow

  • Cleaned up and simplified the systemd service installation logic by

invoking systemctl instead of creating symlinks manually

  • Replaced various hard-coded paths with dracut equivalents to better

conform with expected dracut behaviour

  • Removed redundant call to mkdir (inst_simple creates the parent

directory if it does not exist on the destination initrd)

Reviewed-by: Ahelenia ZiemiaƄska <nabijaczleweli@nabijaczleweli.xyz>
Reviewed-by: Andrew J. Hesford <ajh@sideband.org>
Signed-off-by: Savyasachee Jha <hi@savyasacheejha.com>
Closes #13010

Details

Provenance
Savyasachee Jha <genghizkhan91@hawkradius.com>Authored on Feb 14 2022, 4:58 PM
Brian Behlendorf <behlendorf1@llnl.gov>Committed on May 25 2022, 6:09 PM
Parents
rG4252517f5fad: Remove absolute paths to udev rules and binaries for dracut
Branches
Unknown
Tags
Unknown

Event Timeline

Brian Behlendorf <behlendorf1@llnl.gov> committed rG115e0598180e: Multiple dracut module install script cleanups (authored by Savyasachee Jha <genghizkhan91@hawkradius.com>).May 25 2022, 6:09 PM