HomeFreeBSD

OpenZFS 9454 - ::zfs_blkstats should count embedded blocks

Description

OpenZFS 9454 - ::zfs_blkstats should count embedded blocks

When we do a scrub or resilver, ZFS counts the different types of blocks,
which can be printed by the ::zfs_blkstats mdb dcmd. However, it fails to
count embedded blocks.

Porting notes:

  • Commit d4a72f23 moved count_blocks under a BP_IS_EMBEDDED conditional as part of the sequential resilver functionality. Since phys_birth would be zero that case should never happen as described above. This is confirmed by the code coverage analysis. Remove the conditional to realign that aspect of this function with OpenZFS.

Authored by: Matthew Ahrens <mahrens@delphix.com>
Reviewed by: Dan Kimmel <dan.kimmel@delphix.com>
Reviewed by: George Wilson <george.wilson@delphix.com>
Reviewed by: George Melikov <mail@gmelikov.ru>
Reviewed by: Tom Caputi <tcaputi@datto.com>
Ported-by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Robert Mustacchi <rm@joyent.com>

OpenZFS-issue: https://www.illumos.org/issues/9454
OpenZFS-commit: https://github.com/openzfs/openzfs/commit/d8a447a7
Closes #7697

Details

Provenance
mahrensAuthored on Dec 4 2017, 7:29 PM
Brian Behlendorf <behlendorf1@llnl.gov>Committed on Jul 10 2018, 5:41 PM
Parents
rGab11916583e5: OpenZFS 9456 - ztest failure in zil_commit_waiter_timeout
Branches
Unknown
Tags
Unknown