HomeFreeBSD

devel/fbthrift: Add missing dependency on RocketUpgrade headers to thriftcpp2…

Description

devel/fbthrift: Add missing dependency on RocketUpgrade headers to thriftcpp2 target (D29353)

One source file in this target, async/HeaderClientChannel.cpp,
depends on the generated header RocketUpgradeAsyncClient.h, so it
needs to depend on the target that generates this header.

This causes a build error with samurai due to an incorrect build
order, and can be reproduced with ninja as well by building
thrift/lib/cpp2/CMakeFiles/thriftcpp2.dir/async/HeaderClientChannel.cpp.o
directly with an empty .ninja_deps.

https://github.com/michaelforney/samurai/issues/70

PR: 254678

Details

Provenance
Michael Forney <mforney@mforney.org>Authored on Apr 10 2021, 7:14 AM
tobikCommitted on Apr 10 2021, 7:14 AM
Parents
R11:1d4cfc12c8fa: security/vuxml: Document information disclosure vulnerability in python.
Branches
Unknown
Tags
Unknown

Event Timeline