HomeFreeBSD

net/hostapd-devel: driver_bsd.c: backout upstream IFF_ change and add logging

Description

net/hostapd-devel: driver_bsd.c: backout upstream IFF_ change and add logging

This reverts the state to our old supplicant logic setting or clearing
IFF_UP if needed. In addition this adds logging for the cases in which
we do (not) change the interface state.

Depending on testing this seems to help bringing WiFi up or not log
any needed changes (which would be the expected wpa_supplicant logic
now). People should look out for `(changed)` log entries (at least
if debugging the issue; this way we will at least have data points).

There is a hypothesis still pondered that the entire IFF_UP toggling
only exploits a race in net80211 (see further discssussions for more
debugging and alternative solutions see D38508 and D38753).
That may also explain why the changes to the rc startup script [1]
only helped partially for some people to no longer see the
continuous CTRL-EVENT-SCAN-FAILED.

It is highly likely that we will want further changes and until
we know for sure that people are seeing ''(changed)'' events
this should stay local. Should we need to upstream this we'll
likely need #ifdef FreeBSD around this code.

PR: 273696
Obtained from: src bfb202c4554a

(cherry picked from commit 8668ee87415b8f14a4845b04358ac082aa34ea57)

Details

Provenance
cyAuthored on Sep 11 2023, 6:21 AM
Parents
R11:5d8ede11d81e: net/hostapd: driver_bsd.c: backout upstream IFF_ change and add logging
Branches
Unknown
Tags
Unknown