Page Menu
Home
FreeBSD
Search
Configure Global Search
Log In
Files
F116025695
D39623.id120503.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Flag For Later
Award Token
Size
947 B
Referenced Files
None
Subscribers
None
D39623.id120503.diff
View Options
diff --git a/usr.bin/renice/renice.c b/usr.bin/renice/renice.c
--- a/usr.bin/renice/renice.c
+++ b/usr.bin/renice/renice.c
@@ -94,7 +94,7 @@
}
if (strcmp(*argv, "-n") == 0) {
/* may occur only once, prior to priority */
- if (haveprio || incr)
+ if (haveprio || incr || argc < 2)
usage();
incr = true;
(void)argc--, argv++;
diff --git a/usr.bin/renice/tests/renice_test.sh b/usr.bin/renice/tests/renice_test.sh
--- a/usr.bin/renice/tests/renice_test.sh
+++ b/usr.bin/renice/tests/renice_test.sh
@@ -158,6 +158,11 @@
kill $pid
}
+atf_test_case renice_incr_noarg
+renice_incr_noarg_body() {
+ atf_check -o empty -e ignore -s exit:1 renice -n
+}
+
atf_init_test_cases() {
atf_add_test_case renice_abs_pid
atf_add_test_case renice_rel_pid
@@ -166,4 +171,5 @@
atf_add_test_case renice_abs_user
atf_add_test_case renice_rel_user
atf_add_test_case renice_delim
+ atf_add_test_case renice_incr_noarg
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Fri, May 2, 6:42 PM (13 h, 33 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
17910216
Default Alt Text
D39623.id120503.diff (947 B)
Attached To
Mode
D39623: renice: Avoid segfault if -n flag is given without argument.
Attached
Detach File
Event Timeline
Log In to Comment