Page Menu
Home
FreeBSD
Search
Configure Global Search
Log In
Files
F112700016
D49433.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Flag For Later
Award Token
Size
811 B
Referenced Files
None
Subscribers
None
D49433.diff
View Options
diff --git a/sys/netpfil/pf/pf.c b/sys/netpfil/pf/pf.c
--- a/sys/netpfil/pf/pf.c
+++ b/sys/netpfil/pf/pf.c
@@ -2730,15 +2730,19 @@
NET_EPOCH_ASSERT();
PF_HASHROW_ASSERT(ih);
+ PF_STATE_LOCK(s);
if (s->timeout == PFTM_UNLINKED) {
/*
* State is being processed
* by pf_unlink_state() in
* an other thread.
*/
+ PF_STATE_UNLOCK(s);
PF_HASHROW_UNLOCK(ih);
return (0); /* XXXGL: undefined actually */
}
+ s->timeout = PFTM_UNLINKED;
+ PF_STATE_UNLOCK(s);
if (s->src.state == PF_TCPS_PROXY_DST) {
/* XXX wire key the right one? */
@@ -2760,8 +2764,6 @@
STATE_DEC_COUNTERS(s);
- s->timeout = PFTM_UNLINKED;
-
/* Ensure we remove it from the list of halfopen states, if needed. */
if (s->key[PF_SK_STACK] != NULL &&
s->key[PF_SK_STACK]->proto == IPPROTO_TCP)
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Mar 22, 3:09 PM (21 m, 16 s)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
17254616
Default Alt Text
D49433.diff (811 B)
Attached To
Mode
D49433: pf: do a lock dance in pf_unlink_state()
Attached
Detach File
Event Timeline
Log In to Comment