Page Menu
Home
FreeBSD
Search
Configure Global Search
Log In
Files
F109414942
D35387.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Flag For Later
Award Token
Size
853 B
Referenced Files
None
Subscribers
None
D35387.diff
View Options
diff --git a/sys/netinet/tcp_sack.c b/sys/netinet/tcp_sack.c
--- a/sys/netinet/tcp_sack.c
+++ b/sys/netinet/tcp_sack.c
@@ -965,6 +965,18 @@
}
}
out:
+ KASSERT(SEQ_LT(hole->start, hole->end), ("%s: hole.start >= hole.end", __func__));
+ KASSERT(SEQ_LT(hole->start, tp->snd_fack), ("%s: hole.start >= snd.fack", __func__));
+ KASSERT(SEQ_LT(hole->end, tp->snd_fack), ("%s: hole.end >= snd.fack", __func__));
+ KASSERT(SEQ_LT(hole->rxmit, tp->snd_fack), ("%s: hole.rxmit >= snd.fack", __func__));
+ if (SEQ_GEQ(hole->start, hole->end) ||
+ SEQ_GEQ(hole->start, tp->snd_fack) ||
+ SEQ_GEQ(hole->end, tp->snd_fack) ||
+ SEQ_GEQ(hole->rxmit, tp->snd_fack)) {
+ log(LOG_CRIT,"tcp: invalid SACK hole (%u-%u,%u) vs fwd ack %u, ignoring.\n",
+ hole->start, hole->end, hole->rxmit, tp->snd_fack);
+ return (NULL);
+ }
return (hole);
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Wed, Feb 5, 6:43 PM (20 h, 47 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
16478938
Default Alt Text
D35387.diff (853 B)
Attached To
Mode
D35387: Sanity check of SACK holes on retransmissions
Attached
Detach File
Event Timeline
Log In to Comment