Page Menu
Home
FreeBSD
Search
Configure Global Search
Log In
Files
F108389876
D33285.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Flag For Later
Award Token
Size
1 KB
Referenced Files
None
Subscribers
None
D33285.diff
View Options
diff --git a/sys/dev/nvme/nvme_ahci.c b/sys/dev/nvme/nvme_ahci.c
--- a/sys/dev/nvme/nvme_ahci.c
+++ b/sys/dev/nvme/nvme_ahci.c
@@ -104,7 +104,14 @@
}
ctrlr->tag = (void *)0x1;
- return nvme_attach(dev);
+ /*
+ * We're attached via this funky mechanism. Flag the controller so that
+ * it avoids things that can't work when we do that, like asking for
+ * PCI config space entries.
+ */
+ ctrlr->quirks |= QUIRK_AHCI;
+
+ return (nvme_attach(dev)); /* Note: failure frees resources */
bad:
if (ctrlr->resource != NULL) {
bus_release_resource(dev, SYS_RES_MEMORY,
diff --git a/sys/dev/nvme/nvme_private.h b/sys/dev/nvme/nvme_private.h
--- a/sys/dev/nvme/nvme_private.h
+++ b/sys/dev/nvme/nvme_private.h
@@ -241,6 +241,7 @@
#define QUIRK_DELAY_B4_CHK_RDY 1 /* Can't touch MMIO on disable */
#define QUIRK_DISABLE_TIMEOUT 2 /* Disable broken completion timeout feature */
#define QUIRK_INTEL_ALIGNMENT 4 /* Pre NVMe 1.3 performance alignment */
+#define QUIRK_AHCI 8 /* Attached via AHCI redirect */
bus_space_tag_t bus_tag;
bus_space_handle_t bus_handle;
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Jan 25, 9:53 AM (16 h, 7 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
16136390
Default Alt Text
D33285.diff (1 KB)
Attached To
Mode
D33285: nvme_ahci: Mark AHCI devices as such in the controller
Attached
Detach File
Event Timeline
Log In to Comment