Page Menu
Home
FreeBSD
Search
Configure Global Search
Log In
Files
F108388905
D39736.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Flag For Later
Award Token
Size
1 KB
Referenced Files
None
Subscribers
None
D39736.diff
View Options
diff --git a/sys/netinet/tcp_subr.c b/sys/netinet/tcp_subr.c
--- a/sys/netinet/tcp_subr.c
+++ b/sys/netinet/tcp_subr.c
@@ -3968,6 +3968,13 @@
xt->xt_len = sizeof(struct xtcpcb);
in_pcbtoxinpcb(inp, &xt->xt_inp);
+ /*
+ * TCP doesn't use inp_ppcb pointer, we embed inpcb into tcpcb.
+ * Fixup the pointer that in_pcbtoxinpcb() has set. When printing
+ * TCP netstat(1) used to use this pointer, so this fixup needs to
+ * stay for stable/14.
+ */
+ xt->xt_inp.inp_ppcb = (uintptr_t)tp;
}
void
diff --git a/usr.bin/netstat/inet.c b/usr.bin/netstat/inet.c
--- a/usr.bin/netstat/inet.c
+++ b/usr.bin/netstat/inet.c
@@ -383,16 +383,9 @@
if (Lflag && so->so_qlimit == 0)
continue;
xo_open_instance("socket");
- if (Aflag) {
- if (istcp)
- xo_emit("{q:address/%*lx} ",
- 2 * (int)sizeof(void *),
- (u_long)inp->inp_ppcb);
- else
- xo_emit("{q:address/%*lx} ",
- 2 * (int)sizeof(void *),
- (u_long)so->so_pcb);
- }
+ if (Aflag)
+ xo_emit("{q:address/%*lx} ", 2 * (int)sizeof(void *),
+ (u_long)so->so_pcb);
#ifdef INET6
if ((inp->inp_vflag & INP_IPV6) != 0)
vchar = ((inp->inp_vflag & INP_IPV4) != 0) ?
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Jan 25, 9:40 AM (16 h, 9 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
16135980
Default Alt Text
D39736.diff (1 KB)
Attached To
Mode
D39736: netstat: fix printing of TCP pcbs with -A
Attached
Detach File
Event Timeline
Log In to Comment