Page Menu
Home
FreeBSD
Search
Configure Global Search
Log In
Files
F108235858
D22281.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Flag For Later
Award Token
Size
9 KB
Referenced Files
None
Subscribers
None
D22281.diff
View Options
Index: head/sys/arm64/rockchip/clk/rk_clk_armclk.c
===================================================================
--- head/sys/arm64/rockchip/clk/rk_clk_armclk.c
+++ head/sys/arm64/rockchip/clk/rk_clk_armclk.c
@@ -67,15 +67,19 @@
CLKDEV_WRITE_4(clknode_get_device(_clk), off, val)
#define READ4(_clk, off, val) \
CLKDEV_READ_4(clknode_get_device(_clk), off, val)
-#define DEVICE_LOCK(_clk) \
+#define DEVICE_LOCK(_clk) \
CLKDEV_DEVICE_LOCK(clknode_get_device(_clk))
#define DEVICE_UNLOCK(_clk) \
CLKDEV_DEVICE_UNLOCK(clknode_get_device(_clk))
#define RK_ARMCLK_WRITE_MASK_SHIFT 16
-/* #define dprintf(format, arg...) printf("%s:(%s)" format, __func__, clknode_get_name(clk), arg) */
+#if 0
+#define dprintf(format, arg...) \
+ printf("%s:(%s)" format, __func__, clknode_get_name(clk), arg)
+#else
#define dprintf(format, arg...)
+#endif
static int
rk_clk_armclk_init(struct clknode *clk, device_t dev)
@@ -132,7 +136,7 @@
DEVICE_UNLOCK(clk);
div = ((reg & sc->div_mask) >> sc->div_shift) + 1;
- dprintf("parent_freq=%lu, div=%u\n", *freq, div);
+ dprintf("parent_freq=%ju, div=%u\n", *freq, div);
*freq = *freq / div;
@@ -152,7 +156,7 @@
sc = clknode_get_softc(clk);
- dprintf("Finding best parent/div for target freq of %lu\n", *fout);
+ dprintf("Finding best parent/div for target freq of %ju\n", *fout);
p_names = clknode_get_parent_names(clk);
p_main = clknode_find_by_name(p_names[sc->main_parent]);
@@ -162,7 +166,7 @@
div = sc->rates[i].div;
best_p = best * div;
rate = i;
- dprintf("Best parent %s (%d) with best freq at %lu\n",
+ dprintf("Best parent %s (%d) with best freq at %ju\n",
clknode_get_name(p_main),
sc->main_parent,
best);
@@ -179,17 +183,18 @@
return (0);
}
- dprintf("Changing parent (%s) freq to %lu\n", clknode_get_name(p_main), best_p);
+ dprintf("Changing parent (%s) freq to %ju\n", clknode_get_name(p_main),
+ best_p);
err = clknode_set_freq(p_main, best_p, 0, 1);
if (err != 0)
- printf("Cannot set %s to %lu\n",
+ printf("Cannot set %s to %ju\n",
clknode_get_name(p_main),
best_p);
clknode_set_parent_by_idx(clk, sc->main_parent);
clknode_get_freq(p_main, &best_p);
- dprintf("main parent freq at %lu\n", best_p);
+ dprintf("main parent freq at %ju\n", best_p);
DEVICE_LOCK(clk);
val |= (div - 1) << sc->div_shift;
val |= sc->div_mask << RK_ARMCLK_WRITE_MASK_SHIFT;
Index: head/sys/arm64/rockchip/clk/rk_clk_composite.c
===================================================================
--- head/sys/arm64/rockchip/clk/rk_clk_composite.c
+++ head/sys/arm64/rockchip/clk/rk_clk_composite.c
@@ -61,15 +61,19 @@
CLKDEV_WRITE_4(clknode_get_device(_clk), off, val)
#define READ4(_clk, off, val) \
CLKDEV_READ_4(clknode_get_device(_clk), off, val)
-#define DEVICE_LOCK(_clk) \
+#define DEVICE_LOCK(_clk) \
CLKDEV_DEVICE_LOCK(clknode_get_device(_clk))
#define DEVICE_UNLOCK(_clk) \
CLKDEV_DEVICE_UNLOCK(clknode_get_device(_clk))
#define RK_CLK_COMPOSITE_MASK_SHIFT 16
-/* #define dprintf(format, arg...) printf("%s:(%s)" format, __func__, clknode_get_name(clk), arg) */
+#if 0
+#define dprintf(format, arg...) \
+ printf("%s:(%s)" format, __func__, clknode_get_name(clk), arg)
+#else
#define dprintf(format, arg...)
+#endif
static int
rk_clk_composite_init(struct clknode *clk, device_t dev)
@@ -158,6 +162,7 @@
dprintf("parent_freq=%lu, div=%u\n", *freq, div);
*freq = *freq / div;
+ dprintf("Final freq=%ju\n", *freq);
return (0);
}
@@ -194,20 +199,22 @@
sc = clknode_get_softc(clk);
- dprintf("Finding best parent/div for target freq of %lu\n", *fout);
+ dprintf("Finding best parent/div for target freq of %ju\n", *fout);
p_names = clknode_get_parent_names(clk);
for (best_div = 0, best = 0, p_idx = 0;
p_idx != clknode_get_parents_num(clk); p_idx++) {
p_clk = clknode_find_by_name(p_names[p_idx]);
clknode_get_freq(p_clk, &fparent);
- dprintf("Testing with parent %s (%d) at freq %lu\n", clknode_get_name(p_clk), p_idx, fparent);
+ dprintf("Testing with parent %s (%d) at freq %ju\n",
+ clknode_get_name(p_clk), p_idx, fparent);
div = rk_clk_composite_find_best(sc, fparent, *fout);
cur = fparent / div;
if ((*fout - cur) < (*fout - best)) {
best = cur;
best_div = div;
best_parent = p_idx;
- dprintf("Best parent so far %s (%d) with best freq at %lu\n", clknode_get_name(p_clk), p_idx, best);
+ dprintf("Best parent so far %s (%d) with best freq at "
+ "%ju\n", clknode_get_name(p_clk), p_idx, best);
}
}
@@ -233,7 +240,8 @@
p_idx = clknode_get_parent_idx(clk);
if (p_idx != best_parent) {
- dprintf("Switching parent index from %d to %d\n", p_idx, best_parent);
+ dprintf("Switching parent index from %d to %d\n", p_idx,
+ best_parent);
clknode_set_parent_by_idx(clk, best_parent);
}
@@ -266,7 +274,8 @@
clknode_class);
int
-rk_clk_composite_register(struct clkdom *clkdom, struct rk_clk_composite_def *clkdef)
+rk_clk_composite_register(struct clkdom *clkdom,
+ struct rk_clk_composite_def *clkdef)
{
struct clknode *clk;
struct rk_clk_composite_sc *sc;
Index: head/sys/arm64/rockchip/clk/rk_clk_gate.c
===================================================================
--- head/sys/arm64/rockchip/clk/rk_clk_gate.c
+++ head/sys/arm64/rockchip/clk/rk_clk_gate.c
@@ -45,7 +45,7 @@
CLKDEV_READ_4(clknode_get_device(_clk), off, val)
#define MD4(_clk, off, clr, set ) \
CLKDEV_MODIFY_4(clknode_get_device(_clk), off, clr, set)
-#define DEVICE_LOCK(_clk) \
+#define DEVICE_LOCK(_clk) \
CLKDEV_DEVICE_LOCK(clknode_get_device(_clk))
#define DEVICE_UNLOCK(_clk) \
CLKDEV_DEVICE_UNLOCK(clknode_get_device(_clk))
Index: head/sys/arm64/rockchip/clk/rk_clk_mux.c
===================================================================
--- head/sys/arm64/rockchip/clk/rk_clk_mux.c
+++ head/sys/arm64/rockchip/clk/rk_clk_mux.c
@@ -51,7 +51,7 @@
CLKDEV_READ_4(clknode_get_device(_clk), off, val)
#define MD4(_clk, off, clr, set ) \
CLKDEV_MODIFY_4(clknode_get_device(_clk), off, clr, set)
-#define DEVICE_LOCK(_clk) \
+#define DEVICE_LOCK(_clk) \
CLKDEV_DEVICE_LOCK(clknode_get_device(_clk))
#define DEVICE_UNLOCK(_clk) \
CLKDEV_DEVICE_UNLOCK(clknode_get_device(_clk))
Index: head/sys/arm64/rockchip/clk/rk_clk_pll.c
===================================================================
--- head/sys/arm64/rockchip/clk/rk_clk_pll.c
+++ head/sys/arm64/rockchip/clk/rk_clk_pll.c
@@ -58,19 +58,23 @@
bool normal_mode;
};
-#define WRITE4(_clk, off, val) \
+#define WRITE4(_clk, off, val) \
CLKDEV_WRITE_4(clknode_get_device(_clk), off, val)
-#define READ4(_clk, off, val) \
+#define READ4(_clk, off, val) \
CLKDEV_READ_4(clknode_get_device(_clk), off, val)
-#define DEVICE_LOCK(_clk) \
+#define DEVICE_LOCK(_clk) \
CLKDEV_DEVICE_LOCK(clknode_get_device(_clk))
-#define DEVICE_UNLOCK(_clk) \
+#define DEVICE_UNLOCK(_clk) \
CLKDEV_DEVICE_UNLOCK(clknode_get_device(_clk))
#define RK_CLK_PLL_MASK_SHIFT 16
-/* #define dprintf(format, arg...) printf("%s:(%s)" format, __func__, clknode_get_name(clk), arg) */
+#if 0
+#define dprintf(format, arg...) \
+ printf("%s:(%s)" format, __func__, clknode_get_name(clk), arg)
+#else
#define dprintf(format, arg...)
+#endif
static int
rk_clk_pll_set_gate(struct clknode *clk, bool enable)
@@ -397,13 +401,18 @@
dprintf("con2: %x\n", con3);
dprintf("con3: %x\n", con4);
- fbdiv = (con1 & RK3399_CLK_PLL_FBDIV_MASK) >> RK3399_CLK_PLL_FBDIV_SHIFT;
+ fbdiv = (con1 & RK3399_CLK_PLL_FBDIV_MASK)
+ >> RK3399_CLK_PLL_FBDIV_SHIFT;
- postdiv1 = (con2 & RK3399_CLK_PLL_POSTDIV1_MASK) >> RK3399_CLK_PLL_POSTDIV1_SHIFT;
- postdiv2 = (con2 & RK3399_CLK_PLL_POSTDIV2_MASK) >> RK3399_CLK_PLL_POSTDIV2_SHIFT;
- refdiv = (con2 & RK3399_CLK_PLL_REFDIV_MASK) >> RK3399_CLK_PLL_REFDIV_SHIFT;
+ postdiv1 = (con2 & RK3399_CLK_PLL_POSTDIV1_MASK)
+ >> RK3399_CLK_PLL_POSTDIV1_SHIFT;
+ postdiv2 = (con2 & RK3399_CLK_PLL_POSTDIV2_MASK)
+ >> RK3399_CLK_PLL_POSTDIV2_SHIFT;
+ refdiv = (con2 & RK3399_CLK_PLL_REFDIV_MASK)
+ >> RK3399_CLK_PLL_REFDIV_SHIFT;
- fracdiv = (con3 & RK3399_CLK_PLL_FRAC_MASK) >> RK3399_CLK_PLL_FRAC_SHIFT;
+ fracdiv = (con3 & RK3399_CLK_PLL_FRAC_MASK)
+ >> RK3399_CLK_PLL_FRAC_SHIFT;
fracdiv >>= 24;
dsmpd = (con4 & RK3399_CLK_PLL_DSMPD_MASK) >> RK3399_CLK_PLL_DSMPD_SHIFT;
@@ -415,7 +424,7 @@
dprintf("fracdiv: %d\n", fracdiv);
dprintf("dsmpd: %d\n", dsmpd);
- dprintf("parent freq=%lu\n", *freq);
+ dprintf("parent freq=%ju\n", *freq);
if (dsmpd == 0) {
/* Fractional mode */
@@ -424,10 +433,10 @@
/* Integer mode */
foutvco = *freq / refdiv * fbdiv;
}
- dprintf("foutvco: %lu\n", foutvco);
+ dprintf("foutvco: %ju\n", foutvco);
*freq = foutvco / postdiv1 / postdiv2;
- dprintf("freq: %lu\n", *freq);
+ dprintf("freq: %ju\n", *freq);
return (0);
}
Index: head/sys/arm64/rockchip/clk/rk_cru.c
===================================================================
--- head/sys/arm64/rockchip/clk/rk_cru.c
+++ head/sys/arm64/rockchip/clk/rk_cru.c
@@ -233,10 +233,12 @@
case RK_CLK_UNDEFINED:
break;
case RK3328_CLK_PLL:
- rk3328_clk_pll_register(sc->clkdom, sc->clks[i].clk.pll);
+ rk3328_clk_pll_register(sc->clkdom,
+ sc->clks[i].clk.pll);
break;
case RK3399_CLK_PLL:
- rk3399_clk_pll_register(sc->clkdom, sc->clks[i].clk.pll);
+ rk3399_clk_pll_register(sc->clkdom,
+ sc->clks[i].clk.pll);
break;
case RK_CLK_COMPOSITE:
rk_clk_composite_register(sc->clkdom,
@@ -246,7 +248,8 @@
rk_clk_mux_register(sc->clkdom, sc->clks[i].clk.mux);
break;
case RK_CLK_ARMCLK:
- rk_clk_armclk_register(sc->clkdom, sc->clks[i].clk.armclk);
+ rk_clk_armclk_register(sc->clkdom,
+ sc->clks[i].clk.armclk);
break;
default:
device_printf(dev, "Unknown clock type\n");
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Jan 23, 11:08 PM (20 h, 32 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
16067264
Default Alt Text
D22281.diff (9 KB)
Attached To
Mode
D22281: Cleanup Rockchip clocks implementation.
Attached
Detach File
Event Timeline
Log In to Comment