Page MenuHomeFreeBSD

D32726.diff
No OneTemporary

D32726.diff

diff --git a/sys/kern/subr_syscall.c b/sys/kern/subr_syscall.c
--- a/sys/kern/subr_syscall.c
+++ b/sys/kern/subr_syscall.c
@@ -260,9 +260,15 @@
* the exec event now and then clear TDB_EXEC so that
* the next stop is reported as a syscall exit by
* linux_ptrace_status().
+ *
+ * We are accessing p->p_pptr without any additional
+ * locks here: it cannot change while p is kept locked;
+ * while the debugger could in theory change its ABI
+ * while tracing another process, the outcome of such
+ * a race wouln't be deterministic anyway.
*/
- if ((td->td_dbgflags & TDB_EXEC) != 0 &&
- SV_PROC_ABI(td->td_proc) == SV_ABI_LINUX) {
+ if (traced && (td->td_dbgflags & TDB_EXEC) != 0 &&
+ SV_PROC_ABI(p->p_pptr) == SV_ABI_LINUX) {
ptracestop(td, SIGTRAP, NULL);
td->td_dbgflags &= ~TDB_EXEC;
}

File Metadata

Mime Type
text/plain
Expires
Tue, Jan 14, 5:06 PM (6 h, 48 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
15797468
Default Alt Text
D32726.diff (843 B)

Event Timeline