Page MenuHomeFreeBSD
Differential D7969

add a WITHOUT_DIALOG src.conf knob
ClosedPublic
Actions

Authored by emaste on Sep 20 2016, 1:50 PM.
Tags
None
Referenced Files
F103039252: D7969.diff
Wed, Nov 20, 3:41 AM
Unknown Object (File)
Sat, Nov 16, 7:15 AM
Unknown Object (File)
Thu, Nov 14, 2:18 PM
Unknown Object (File)
Tue, Nov 5, 4:49 PM
Unknown Object (File)
Tue, Oct 29, 6:36 AM
Unknown Object (File)
Oct 14 2024, 4:40 PM
Unknown Object (File)
Oct 11 2024, 11:23 PM
Unknown Object (File)
Oct 10 2024, 9:21 PM
View All 63 Files
Subscribers
bdrewery

Details

Reviewers
dteske
bapt
Commits
rS306375: Add a WITHOUT_DIALOG src.conf(5) knob
Summary

It disables dialog, libdialog, and dependencies (libdpv and dpv).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste updated this revision to Diff 20528.Sep 20 2016, 1:50 PM
emaste retitled this revision from to add a WITHOUT_DIALOG src.conf knob.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added reviewers: dteske, bapt.
emaste added a subscriber: bdrewery.
emaste updated this revision to Diff 20529.Sep 20 2016, 1:54 PM

bsdinstall, bsdconfig, tzsetup depend on dialog

dteske added inline comments.Sep 20 2016, 11:42 PM
tools/build/mk/OptionalObsoleteFiles.inc
1349 ↗(On Diff #20529)

don't forget usr/share/man/man3/dpv.3.gz

dteske added inline comments.Sep 20 2016, 11:46 PM
tools/build/mk/OptionalObsoleteFiles.inc
1348 ↗(On Diff #20529)

don't forget usr/share/man/man3/dialog.3.gz

tools/build/options/WITHOUT_DIALOG
2 ↗(On Diff #20529)

dialog(1), libdialog => dialog(1,3)
dpv(1) => dpv(1,3)

dteske added inline comments.Sep 20 2016, 11:50 PM
tools/build/mk/OptionalObsoleteFiles.inc
1339 ↗(On Diff #20529)

maybe add below this line usr/sbin/tzsetup

Adding bsdinstall and bsdconfig here might be a bit harder because they have sprawl

1350 ↗(On Diff #20529)

Should we add here (above the .endif):

usr/share/man/man8/tzsetup.8.gz
usr/share/man/man8/bsdconfig.8.gz
usr/share/man/man8/bsdinstall.8.gz

emaste updated this revision to Diff 20580.Sep 21 2016, 1:07 PM

updates from @dteske

emaste marked 5 inline comments as done.Sep 21 2016, 1:10 PM
emaste added inline comments.
tools/build/mk/OptionalObsoleteFiles.inc
1350 ↗(On Diff #20529)

bsdinstall has its own knob and MK_DIALOG=no forces MK_BSDINSTALL=no, so bsdinstall will be taken care of that way.

emaste marked an inline comment as done.Sep 26 2016, 5:28 PM

ping?

dteske accepted this revision.Sep 26 2016, 5:43 PM
dteske edited edge metadata.
This revision is now accepted and ready to land.Sep 26 2016, 5:43 PM
Closed by commit rS306375: Add a WITHOUT_DIALOG src.conf(5) knob (authored by emaste). · Explain WhySep 27 2016, 6:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
10 lines
gnu/
usr.bin/
3 lines
lib/
3 lines
share/
mk/
5 lines
tools/
build/
mk/
21 lines
options/
2 lines
usr.bin/
2 lines
usr.sbin/
4 lines

Diff 20744

View Options

head/Makefile.inc1

Loading...
View Options

head/gnu/usr.bin/Makefile

Loading...
View Options

head/lib/Makefile

Loading...
View Options

head/share/mk/src.opts.mk

Loading...
View Options

head/tools/build/mk/OptionalObsoleteFiles.inc

Loading...
View Options

head/tools/build/options/WITHOUT_DIALOG

Loading...
View Options

head/usr.bin/Makefile

Loading...
View Options

head/usr.sbin/Makefile

Loading...