Add STATIC option to x11-fonts/fontconfig

[cy]

Summary

I h ave a requirement to statically link x11/xforward. Unfortunately x11-fonts/fontconfig does not install static (.a) libraries. The patch in this differential revision adds the option to install a static libfontconfig.a library.

Test Plan

A new x11/xforward-static port has been created locally and tested using a locally updated x11/fontconfig port with ENABLE_STATIC on my firewall/gateway, which does not have X installed. The test has passed.

[kwm]

x11-fonts/fontconfig/Makefile

43 ↗

(On Diff #15755)

Could you rename the option to STATIC? OPTIONS already implies enable/disable.

44 ↗

(On Diff #15755)

When renamed this lines can be removed, as the STATIC define is in bsd.options.desc.mk.

45 ↗

(On Diff #15755)

STATIC_CONFIGURE_ENABLE=static

[cy]

Changed ENABLE_STATIC to STATIC.

[cy]

STATIC_CONFIGURE_ENABLE= also set

[dumbbell]

Do we really need an option? Can't the port always install the static library?

[bapt]

In D6155#131417, @dumbbell wrote:

Do we really need an option? Can't the port always install the static library?

/me 100% agrees

[zeising]

In D6155#131419, @bapt wrote:

In D6155#131417, @dumbbell wrote:

Do we really need an option? Can't the port always install the static library?

/me 100% agrees

I also agree with this. I see no need to have a separate option for this.
Other than that, I see no problem in approving this.

[cy]

Sure, static it is.

[cy]

If people are happy with this, I'll commit it and move onto xforward.

[kwm]

Yeah this is fine too. Could you add a comment though why static is enabled? Otherwise someone might remove it in a future updated (probably me..).