Page MenuHomeFreeBSD

Move mount related functions into libmount
Needs ReviewPublic

Authored by dim on Tue, Apr 22, 10:03 AM.
Tags
None
Referenced Files
F115314716: D49958.id.diff
Tue, Apr 22, 12:33 PM
F115314385: D49958.id154083.diff
Tue, Apr 22, 12:28 PM
F115312059: D49958.id.diff
Tue, Apr 22, 12:05 PM
F115309889: D49958.id154083.diff
Tue, Apr 22, 11:34 AM
F115309182: D49958.diff
Tue, Apr 22, 11:23 AM
F115307860: D49958.diff
Tue, Apr 22, 11:04 AM

Details

Summary

This avoids several programs using .PATH to reach over into the
sbin/mount subdirectory to recompile getmntopts.c, mounttab.c or
vfslist.c, namely:

  • sbin/fsck
  • sbin/fsck_ffs
  • sbin/growfs
  • sbin/init
  • sbin/mksnap_ffs
  • sbin/mount_cd9660
  • sbin/mount_fusefs
  • sbin/mount_msdosfs
  • sbin/mount_nfs
  • sbin/mount_nullfs
  • sbin/mount_udf
  • sbin/mount_unionfs
  • sbin/tunefs
  • sbin/umount
  • tests/sys/fs/fusefs
  • usr.sbin/autofs
  • usr.sbin/mount_smbfs
  • usr.sbin/mountd
  • usr.sbin/rpc.umntall

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 63627
Build 60511: arc lint + arc unit

Event Timeline

dim requested review of this revision.Tue, Apr 22, 10:03 AM

Sorry, I should have added you to D49951 and D49952 which this duplicates. I don't think a new library is warranted and if it is, it should probably be libmntopts or the like not something as generic as libmount.

I've commented on one makefile with some complaints that apply to most of them.

usr.sbin/mountd/Makefile
2

This line is now is gratuitous (SRCS=${PROG}.c by default)

5

The installed copy should be used.