linuxkpi: Only reset task state if non-indefinite timeout in `schedule_timeout()`
Needs ReviewPublic
Actions

Authored by dumbbell on Sat, Apr 19, 2:02 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 26, 4:58 AM

	Unknown Object (File)
	Fri, Apr 25, 9:32 AM

	Unknown Object (File)
	Fri, Apr 25, 3:09 AM

	Unknown Object (File)
	Wed, Apr 23, 7:25 AM

	Unknown Object (File)
	Tue, Apr 22, 6:24 AM

	Unknown Object (File)
	Sat, Apr 19, 10:18 PM

	Unknown Object (File)
	Sat, Apr 19, 9:58 PM

	Unknown Object (File)
	Sat, Apr 19, 9:57 PM

View All 11 Files

Subscribers

emaste

imp

Details

Reviewers

markj

Group Reviewers

linuxkpi

Summary

On Linux, if there is no specified timeout (i.e., the timeout is set to MAX_SCHEDULE_TIMEOUT), the task state is left unchanged.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dumbbell created this revision.Sat, Apr 19, 2:02 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptSat, Apr 19, 2:02 PM

dumbbell requested review of this revision.Sat, Apr 19, 2:02 PM

dumbbell mentioned this in D48755: linuxkpi: Add `woken_wake_function()` and `wait_woken()` .

On Linux, if there is no specified timeout (i.e., the timeout is set to MAX_SCHEDULE_TIMEOUT), the task state is left unchanged.

The herald comment for schedule_timeout() also states that the thread state is guaranteed to be TASK_RUNNING upon return. I'd assume that something in the scheduler resets the task state.

Is one of the drm drivers actually affected by this?

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

src/

linux_schedule.c

3 lines

Diff 153917

View Options

sys/compat/linuxkpi/common/src/linux_schedule.c

linuxkpi: Only reset task state if non-indefinite timeout in `schedule_timeout()`Needs ReviewPublicActions