Mk/bsd.ccache.mk: Make cmake support more flexible
Needs ReviewPublic
Actions

Authored by madpilot on Fri, Apr 4, 1:57 PM.

Details

Reviewers

yuri
rene

Group Reviewers

portmgr

Summary

With commit R11:56538adacf53391307f687155be3fc787a95f40b to ports, I noticed an issue with poudriere, I was not able to disble using ccache for single ports (depending on cmake) by defining NO_CCACHE, looks like this commit ignores that varaible.

I also noticed that the commit hardcodes "ccache" as a binary name.

My patch puts the stanza in the general conditional so it is enabled only when ccache is being actually used. I'm also making the value use the variable CCACHE_BIN, which could be configured by the user.

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 63347
Build 60231: arc lint + arc unit

Event Timeline

madpilot requested review of this revision.Fri, Apr 4, 1:57 PM

madpilot created this revision.

Harbormaster completed remote builds in B63321: Diff 153150.Fri, Apr 4, 1:57 PM

madpilot edited the summary of this revision. (Show Details)Fri, Apr 4, 1:59 PM

rene added a reviewer: portmgr.Sat, Apr 5, 5:31 PM

yuri accepted this revision.Sun, Apr 6, 3:52 AM

This revision is now accepted and ready to land.Sun, Apr 6, 3:52 AM

diizzy added a subscriber: diizzy.Sun, Apr 6, 11:13 AM

diizzy added inline comments.

Mk/bsd.ccache.mk
112	From what I can tell by CMake's documentation this is an invalid option. https://cmake.org/cmake/help/latest/envvar/CMAKE_LANG_COMPILER_LAUNCHER.html

madpilot added inline comments.Sun, Apr 6, 12:49 PM

Mk/bsd.ccache.mk
112	Sorry I don't understand, you mean the `CPP` variant is invalid? It is not perfectly clear from the documentation page you link, but it is quite possible. Some other code I saw using this made me think it was valid though. I'm asking just to understand, no problem in dropping this line from my patch.