Page MenuHomeFreeBSD

tcp: improve initializing the fields in tcp_log_buffer
ClosedPublic

Authored by tuexen on Wed, Apr 2, 8:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 17, 2:47 AM
Unknown Object (File)
Mon, Apr 14, 12:06 PM
Unknown Object (File)
Sun, Apr 13, 2:24 PM
Unknown Object (File)
Sun, Apr 13, 6:39 AM
Unknown Object (File)
Sat, Apr 5, 3:31 PM
Unknown Object (File)
Sat, Apr 5, 12:09 PM
Unknown Object (File)
Sat, Apr 5, 4:57 AM
Unknown Object (File)
Fri, Apr 4, 7:19 PM

Details

Summary

Initialize the fields in the tcp_log_buffer in the sequence they appear in the structure and add the initialization of tlb_flex1, tlb_flex2, and _pad[].

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tuexen requested review of this revision.Wed, Apr 2, 8:56 PM

IMHO, these macros are more obfuscation than a helper. I would write one big sparse initializer here and let compiler optimize wrt padding zeroing.

This revision is now accepted and ready to land.Thu, Apr 3, 10:51 AM

Note I do agree with Gleb here, these macros are just nasty and not very clear. However I think that making such a change should be a separate commit from this one!