Page MenuHomeFreeBSD

Correct CTLTYPE of SYSCTL_SBINTIME_MSEC etc
ClosedPublic

Authored by cperciva on Mon, Mar 31, 4:13 AM.
Tags
None
Referenced Files
F113726556: D49584.diff
Wed, Apr 2, 3:59 PM
Unknown Object (File)
Mon, Mar 31, 8:38 PM
Unknown Object (File)
Mon, Mar 31, 6:15 PM
Unknown Object (File)
Mon, Mar 31, 3:14 PM
Subscribers
None

Details

Summary

These should be CTLTYPE_S64, not CTLTYPE_INT, since they handle 64-bit
values.

Fixes: 003ffd57fee1 ("Add sysctl_usec_to_sbintime [...]")
MFC after: 2 weeks
Sponsored by: Amazon

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cperciva created this revision.

I have similar changes in my tree... Or it appears I do...

But this doesn't matter to iosched: the size here only determines the size of the time interval that can be specified. iosched specifies in the 1-3 digit microseconds, while the range is up to 25 seconds. And the msec one has days of range. It's a good change none-the-less, though.

This revision is now accepted and ready to land.Wed, Apr 2, 3:48 PM
This revision was automatically updated to reflect the committed changes.