pci: Only re-route IRQs based on firmware on x86
ClosedPublic
Actions

Authored by cperciva on Fri, Mar 28, 6:12 PM.

Details

Reviewers

jhb
imp

Commits

rG0e33c2e6df7a: pci: Only re-route IRQs based on firmware on x86

Summary

There is a (very historical) call to pci_assign_interrupt for the
purpose of routing IRQs which may have been set up wrong by x86 BIOS
or firmware. On non-x86 systems, this is unnecessary; and on INTRNG
systems it results in a (synthetic) IRQ leak and ultimately a kernel
panic after many hotplug/unplug cycles.

Suggested by: jhb
MFC after: 2 weeks
Sponsored by: Amazon

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cperciva requested review of this revision.Fri, Mar 28, 6:12 PM

cperciva created this revision.

Harbormaster completed remote builds in B63186: Diff 152809.Fri, Mar 28, 6:13 PM

cperciva mentioned this in D49543: Correctly track index of first free irq map entry.Fri, Mar 28, 6:32 PM

jhb accepted this revision.Fri, Mar 28, 6:43 PM

This revision is now accepted and ready to land.Fri, Mar 28, 6:43 PM

Closed by commit rG0e33c2e6df7a: pci: Only re-route IRQs based on firmware on x86 (authored by cperciva). · Explain WhySat, Mar 29, 8:18 PM

This revision was automatically updated to reflect the committed changes.

cperciva added a commit: rG0e33c2e6df7a: pci: Only re-route IRQs based on firmware on x86.

Could it bring a new flow of messages into the kernel message buffer? After today's upgrade of my desktop PC, I see plenty of "Can't enable IRQ/MSI because no handler is installed," which didn't appear in the past.

It was triggered by D49543 (likely) and seems to be harmless so far.

Revision Contents
Changeset List

Path

Size

sys/

dev/

pci/

pci.c

2 lines

Diff 152851

View Options

pci: Only re-route IRQs based on firmware on x86ClosedPublicActions