Page MenuHomeFreeBSD

kern.opts.mk: Remove EFI from riscv BROKEN OPTIONS
ClosedPublic

Authored by emaste on Fri, Mar 28, 1:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 1, 3:18 AM
Unknown Object (File)
Sun, Mar 30, 9:45 PM
Unknown Object (File)
Sun, Mar 30, 5:14 PM
Unknown Object (File)
Sun, Mar 30, 12:18 PM
Unknown Object (File)
Sun, Mar 30, 9:20 AM
Unknown Object (File)
Fri, Mar 28, 6:00 PM
Subscribers

Details

Summary

Make this consistent with EFI's per-arch defaults in src.opts.mk. We build EFI boot programs for RISC-V.

This discrepancy previously caused make makeman to warn riscv/riscv64: ignoring duplicate option EFI.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.
emaste added a reviewer: mhorne.

Aside from the warning, this should be a no-op, as the only thing gated behind this knob on the kernel side is sys/modules/efirt, which still has an additional MACHINE_CPUARCH check around it.

This revision is now accepted and ready to land.Fri, Mar 28, 5:11 PM

Yeah, my motivation here is just the warning from make makeman. I'll note in the commit message that this is NFC.

Shouldn't src.conf.5 (make makeman) be regenerated after this change?