Page MenuHomeFreeBSD

vm_fault: update page pred after lock rel/acq in copy_entry
ClosedPublic

Authored by dougm on Mar 26 2025, 4:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 26, 9:12 AM
Unknown Object (File)
Sat, Apr 26, 1:05 AM
Unknown Object (File)
Fri, Apr 25, 10:06 PM
Unknown Object (File)
Fri, Apr 25, 7:02 PM
Unknown Object (File)
Fri, Apr 25, 5:12 PM
Unknown Object (File)
Fri, Apr 25, 9:33 AM
Unknown Object (File)
Fri, Apr 25, 8:27 AM
Unknown Object (File)
Mon, Apr 21, 11:23 PM
Subscribers

Details

Summary

In vm_fault_copy_entry, variable 'mpred' is invalided as the predecessor of the next page to be inserted when an allocation failure leads to lock release and reacquisition. Recompute it in that case.

Addresses a problem identified by @markj in D49103.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dougm requested review of this revision.Mar 26 2025, 4:27 PM
dougm created this revision.

Sorry, that was all to complicated. Simplify.

Update the correct variable.

Could you please include a Fixes tag in the commit log?

This revision is now accepted and ready to land.Mar 27 2025, 8:58 AM
This revision was automatically updated to reflect the committed changes.
sys/vm/vm_fault.c
2211

Sorry I didn't catch this - this should be dst_object, not src_object.