ifnet: Refactor out the detaching of address family dependent data to dedicated function
Needs RevisionPublic
Actions

Authored by zlei on Fri, Mar 21, 10:28 AM.

Details

Reviewers

Group Reviewers

Summary

This makes the main logic of if_detach_internal() more clear. It is also easier to read the logic of attaching and detaching address family dependent data.

No functional change intended.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

zlei created this revision.Fri, Mar 21, 10:28 AM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptFri, Mar 21, 10:28 AM

@glebius This may conflict with your local work ~

No, I don't agree this makes code more clear. A single time use function just requires the reader to jump more around the file to understand how things work, also keeping in mind what resources are held or not during those calls.

So my approval of D49444 is in the scope of the original function, not on top of this revision.

This revision now requires changes to proceed.Sat, Mar 22, 6:40 AM

Revision Contents
Changeset List

Path

Size

sys/

net/

if.c

48 lines

Diff 152492

View Options

ifnet: Refactor out the detaching of address family dependent data to dedicated functionNeeds RevisionPublicActions