Paths

Table of Contentst

Differential D49381

linuxkpi: Add `seq_hex_dump()`
AbandonedPublic
Actions

Authored by dumbbell on Mar 15 2025, 11:19 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 14, 10:50 AM

	Unknown Object (File)
	Mon, Apr 7, 11:35 AM

	Unknown Object (File)
	Fri, Apr 4, 5:04 AM

	Unknown Object (File)
	Fri, Apr 4, 4:49 AM

	Unknown Object (File)
	Thu, Apr 3, 7:24 PM

	Unknown Object (File)
	Mon, Mar 31, 8:08 AM

	Unknown Object (File)
	Fri, Mar 21, 10:02 AM

	Unknown Object (File)
	Tue, Mar 18, 10:08 PM

View All 9 Files

Subscribers

Details

Reviewers

Group Reviewers

Summary

It is a copy of print_hex_dump() but uses a struct sbuf as the destination.

The amdgpu DRM driver started to use it in Linux 6.8.

This is part of the update of DRM drivers to Linux 6.8.

Sponsored by: The FreeBSD Foundation

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dumbbell created this revision.Mar 15 2025, 11:19 AM

Herald added subscribers: emaste, imp. · View Herald TranscriptMar 15 2025, 11:19 AM

dumbbell requested review of this revision.Mar 15 2025, 11:19 AM

bz mentioned this in D49637: LinuxKPI: add seq_hex_dump().Wed, Apr 2, 6:13 PM

Alternatively I quickly hacked this up -- I don't know which one would be preferable: https://reviews.freebsd.org/D49637

sys/compat/linuxkpi/common/src/linux_seq_file.c
317	For all of these printfs with prefix_str you need an extra %s and check (prefix_str != NULL) ? " " : "" to get the extra space after
320	I think the original implementation of print_hex_dump() got switched to #tx on purpose

bz requested changes to this revision.Wed, Apr 2, 6:15 PM

This revision now requires changes to proceed.Wed, Apr 2, 6:15 PM

Superseded by D49637.

bz mentioned this in rG4359672e656a: LinuxKPI: add seq_hex_dump().Sat, Apr 12, 8:49 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

3 lines

src/

linux_seq_file.c

49 lines

Diff 152308

sys/compat/linuxkpi/common/include/linux/seq_file.h

Loading...

sys/compat/linuxkpi/common/src/linux_seq_file.c

Loading...