Paths

Table of Contentst

Differential D49373

isspace.3: Fix list block
Needs ReviewPublic
Actions

Authored by jlduran on Sat, Mar 15, 6:35 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Mar 18, 4:52 PM

	Unknown Object (File)
	Sun, Mar 16, 10:29 AM

	Unknown Object (File)
	Sun, Mar 16, 2:39 AM

	Unknown Object (File)
	Sun, Mar 16, 1:39 AM

	Unknown Object (File)
	Sat, Mar 15, 10:51 PM

Subscribers

Details

Reviewers

Group Reviewers

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62935
Build 59819: arc lint + arc unit

Event Timeline

jlduran created this revision.Sat, Mar 15, 6:35 AM

Herald added subscribers: ziaee, imp. · View Herald TranscriptSat, Mar 15, 6:35 AM

jlduran requested review of this revision.Sat, Mar 15, 6:35 AM

Harbormaster completed remote builds in B62932: Diff 152295.Sat, Mar 15, 6:35 AM

ziaee added inline comments.Sat, Mar 15, 4:27 PM

lib/libc/locale/isspace.3
54	These were previously ordered according to ASCII?
55
57	These aren't sentences, so I prefer to use nothing (and lowercase first character, this is how they did it in the beginning); you could use a comma, but you certainly shouldn't use a period.

Address suggestions:

Sort entries according to ascii(7)
Use the "standard" "indent" width
Lowercase the items

Also:

Remove the reference to a historical 386BSD (it no longer applies)

Harbormaster completed remote builds in B62935: Diff 152324.Sat, Mar 15, 7:15 PM

jlduran edited the summary of this revision. (Show Details)Sat, Mar 15, 7:15 PM

jlduran marked 3 inline comments as done.

Note to self: isdigit(3) also needs a little fix.

Revision Contents
Changeset List

Path

Size

lib/

libc/

locale/

18 lines

Diff 152324

lib/libc/locale/isspace.3

Loading...