Page MenuHomeFreeBSD

netinet6: Remove set but not used global variable in6_maxmtu
AcceptedPublic

Authored by zlei on Mar 14 2025, 11:53 AM.
Tags
None
Referenced Files
F114624450: D49357.id153432.diff
Mon, Apr 14, 1:48 PM
F114624423: D49357.id152255.diff
Mon, Apr 14, 1:47 PM
F114624418: D49357.id.diff
Mon, Apr 14, 1:47 PM
Unknown Object (File)
Thu, Apr 10, 6:08 PM
Unknown Object (File)
Mon, Apr 7, 12:38 AM
Unknown Object (File)
Sun, Apr 6, 6:17 PM
Unknown Object (File)
Sun, Apr 6, 11:55 AM
Unknown Object (File)
Thu, Mar 20, 2:52 AM
Subscribers

Details

Reviewers
glebius
melifaro
Group Reviewers
network
transport
Summary

This was introduced by the KAME project, but it appears to serve no purpose.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

zlei requested review of this revision.Mar 14 2025, 11:53 AM
sys/netinet6/nd6_rtr.c
555–560

This can be simplified and avoids extra memory write if MTU didn't change.

		if (mtu <= maxmtu && ndi->linkmtu != mtu);
			ndi->linkmtu = mtu;
			rt_updatemtu(ifp);
		} else {
sys/netinet6/nd6_rtr.c
555–560

This can be simplified and avoids extra memory write if MTU didn't change.

Emm, then the else block

	nd6log((LOG_INFO, "%s: bogus mtu=%lu sent from %

may lost reporting when mtu > maxmtu && ndi->linkmtu == mtu .

sys/netinet6/nd6_rtr.c
555–560

may lost reporting when mtu > maxmtu && ndi->linkmtu == mtu

The above is wrong.

May falsely report bogus mtu when ndi->linkmtu == mtu.

Removed local var change.

This revision is now accepted and ready to land.Thu, Apr 10, 3:29 PM