Page MenuHomeFreeBSD

igc(4): Fix attach for I226-K and LMVP devices
ClosedPublic

Authored by erj on Feb 27 2025, 1:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 4, 12:13 AM
Unknown Object (File)
Mon, Mar 3, 11:56 PM
Unknown Object (File)
Mon, Mar 3, 11:50 PM
Unknown Object (File)
Mon, Mar 3, 6:22 PM
Unknown Object (File)
Mon, Mar 3, 2:59 PM
Unknown Object (File)
Mon, Mar 3, 10:36 AM
Unknown Object (File)
Mon, Mar 3, 10:27 AM
Unknown Object (File)
Sat, Mar 1, 4:14 AM
Subscribers

Details

Summary

The device IDs for these were in the driver's list of PCI ids to attach
to, but igc_set_mac_type() had never been setup to set the correct mac
type for these devices. Fix this by adding these IDs to the switch block
in order for them to be recognized by the driver instead of returning an
error.

This fixes the igc(4) attach for the I226-K LOM on the ASRock Z790
PG-ITX/TB4 motherboard, allowing it to be recognized and used.

Signed-off-by: Eric Joyner <erj@freebsd.org>

MFC after: 3 days
Relnotes: yes

Test Plan

Attach works on the I226-K, but I haven't been able to verify functionality with it. I don't have an I226-LMVP to test with, but I hope that works, too.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

erj requested review of this revision.Feb 27 2025, 1:40 AM
erj added a reviewer: Intel Networking.
This revision is now accepted and ready to land.Feb 27 2025, 2:36 AM

I can now confirm that the I226-K doesn't need any extra changes to work properly; it links at 2.5G and DHCP works:

igc0: flags=1008843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST,LOWER_UP> metric 0 mtu 1500                                                                        
        options=4e427bb<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,JUMBO_MTU,VLAN_HWCSUM,TSO4,TSO6,LRO,WOL_MAGIC,VLAN_HWTSO,RXCSUM_IPV6,TXCSUM_IPV6,HWSTATS,MEXTPG>
        ether xx:xx:xx:xx:xx:xx                                                                                                                               
        inet 192.168.1.138 netmask 0xffffff00 broadcast 192.168.1.255                                                                                         
        media: Ethernet autoselect (2500Base-T <full-duplex>)                                                                                                 
        status: active                                                                                                                                        
        nd6 options=29<PERFORMNUD,IFDISABLED,AUTO_LINKLOCAL>

I'll land this shortly.

This revision was automatically updated to reflect the committed changes.