tests: carp: Update unicast_v4 to catch PR 284872
ClosedPublic
Actions

Authored by zlei on Thu, Feb 20, 10:32 AM.

Details

Reviewers

Group Reviewers

Commits

rGd8d8b9c9ca38: tests: carp: Update test case unicast_v4 to catch PR 284872
rG93fbdef51a13: tests: carp: Update test case unicast_v4 to catch PR 284872

Summary

In the current test case unicast_v4, host one acts as a router, but it uses if_bridge(4) to verify the reachability to CARP master. Unfortunately, if_bridge(4) brings the two CARP hosts into the same broadcast domain, thus with an unusual (undocumented) setup, one host is in unicast mode but another one in multicast, or two hosts are both in multicast mode, the test case can falsely report success.

Fix that by propagating route via routed(8).

PR 284872 shows that CARP(4) happens to send packets with multicast destination when the unicast peer address is x.x.x.224. Update the test to cover that bug.

PR: 284872
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zlei created this revision.Thu, Feb 20, 10:32 AM

Herald added subscribers: glebius, melifaro, asomers, imp. · View Herald TranscriptThu, Feb 20, 10:32 AM

zlei requested review of this revision.Thu, Feb 20, 10:32 AM

zlei mentioned this in D49053: carp: Fix checking IPv4 multicast address.Thu, Feb 20, 10:34 AM

This just needs the comment from D49053 explaining why the bridge is removed in the commit message.

This revision is now accepted and ready to land.Thu, Feb 20, 6:16 PM

Use prefex len 32 for virtual host ip
Use RIPv2, for classless network ( /32 ).
Shorten the wait time for route propagation, routed will query its neighbors immediately on startup, 3 seconds should be sufficient on busy test machine.
Added comment why use peer address x.x.x.224.

This revision now requires review to proceed.Sat, Feb 22, 12:12 PM

Updated the description, should be clear enough now. @kp Does this look good to you ?

zlei edited the summary of this revision. (Show Details)Sat, Feb 22, 5:58 PM

kp accepted this revision as: kp.Sat, Feb 22, 6:35 PM

This revision is now accepted and ready to land.Sat, Feb 22, 6:35 PM

Closed by commit rG93fbdef51a13: tests: carp: Update test case unicast_v4 to catch PR 284872 (authored by zlei). · Explain WhySat, Feb 22, 7:29 PM

This revision was automatically updated to reflect the committed changes.

zlei added a commit: rG93fbdef51a13: tests: carp: Update test case unicast_v4 to catch PR 284872.

zlei added a commit: rGd8d8b9c9ca38: tests: carp: Update test case unicast_v4 to catch PR 284872.Tue, Feb 25, 4:02 AM