Page MenuHomeFreeBSD

style: Recomend SPDX licenses
ClosedPublic

Authored by ziaee on Tue, Feb 18, 9:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 15, 10:01 PM
Unknown Object (File)
Wed, Mar 12, 9:21 AM
Unknown Object (File)
Fri, Mar 7, 7:41 AM
Unknown Object (File)
Fri, Feb 28, 4:50 PM
Unknown Object (File)
Thu, Feb 27, 5:25 PM
Unknown Object (File)
Tue, Feb 25, 4:35 AM
Unknown Object (File)
Tue, Feb 25, 3:29 AM
Unknown Object (File)
Mon, Feb 24, 4:10 AM
Subscribers

Details

Summary

While here, take this opportunity to update the copyright and clean
some mdoc errors.

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ziaee requested review of this revision.Tue, Feb 18, 9:26 PM

Generally, I like these changes. Had one small suggestion, but feel free to take or leave.

share/man/man9/style.9
79

"copyright line or lines" maybe?

This revision is now accepted and ready to land.Tue, Feb 18, 9:28 PM

"copyright lines" is much better, thanks!

This revision now requires review to proceed.Tue, Feb 18, 9:35 PM

Approved.

share/man/man9/style.9
73

Right, I sort of remember the recent choice to say "copyright first, SPDX second". It still is backwards from the precedent set by our existing source code...

But this advice is consistent with the license guide, so LGTM.

https://docs.freebsd.org/en/articles/license-guide/

This revision is now accepted and ready to land.Mon, Feb 24, 3:03 PM
imp added inline comments.
share/man/man9/style.9
73

We changed to the standard that's more widely practiced. It's not 100%, but it is more often (except for mechanically added tags in, eg, linux).

The existing precedent was set by just adding a tag before the entire body of the text, which generally isn't done (we invented something weird).

So the license guide realigns our weird thing with the rest of the industry.

This revision was automatically updated to reflect the committed changes.