Page MenuHomeFreeBSD
Differential D49036

[phb][Uses]: Add missing Uses=mpi
ClosedPublic
Actions

Authored by fernape on Mon, Feb 17, 7:25 PM.

Details

Reviewers
thierry
Commits
R9:198de88111ef: [phb][Uses]: Add missing Uses=mpi

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 62489
Build 59373: arc lint + arc unit

Event Timeline

fernape requested review of this revision.Mon, Feb 17, 7:25 PM
fernape created this revision.
Harbormaster completed remote builds in B62489: Diff 151122.Mon, Feb 17, 7:25 PM
fernape added a reviewer: thierry.Mon, Feb 17, 7:26 PM
thierry added a comment.Mon, Feb 17, 10:19 PM

Seems fine, but it would be better to write MPI_HOME set to $LOCALBASE for MPICH, even if MPICH is the default.

documentation/content/en/books/porters-handbook/uses/_index.adoc
1551–1552

Remark: MPI_HOME is set to $LOCALBASE only for MPICH.

fernape updated this revision to Diff 151156.Tue, Feb 18, 6:50 PM

Addressing feedback.

Harbormaster completed remote builds in B62505: Diff 151156.Tue, Feb 18, 6:51 PM
fernape marked an inline comment as done.Tue, Feb 18, 6:51 PM
thierry accepted this revision.Tue, Feb 18, 6:58 PM

Thanks!

This revision is now accepted and ready to land.Tue, Feb 18, 6:58 PM
fernape added a comment.Fri, Feb 21, 4:24 PM

Thanks for the review!

Closed by commit R9:198de88111ef: [phb][Uses]: Add missing Uses=mpi (authored by fernape). · Explain WhyFri, Feb 21, 4:24 PM
This revision was automatically updated to reflect the committed changes.
fernape added a commit: R9:198de88111ef: [phb][Uses]: Add missing Uses=mpi.

Revision Contents
Changeset List

PathSize
documentation/
content/
en/
books/
porters-handbook/
uses/
42 lines

Diff 151122

View Options

documentation/content/en/books/porters-handbook/uses/_index.adoc

Loading...