Paths

Table of Contentst

Differential D49008

cc_cubic: remove redundant code
ClosedPublic
Actions

Authored by cc on Fri, Feb 14, 4:15 PM.

Tags

None

Referenced Files

	F110595274: D49008.diff
	Thu, Feb 20, 4:11 PM

	Unknown Object (File)
	Tue, Feb 18, 9:15 AM

Subscribers

Details

Reviewers

rscheff
tuexen

Group Reviewers

Commits

rG7f9ef5c75fd1: cc_cubic: remove redundant code

Summary

During my progress on updating cc_cubic to RFC9438, found such redundancy as:

W_est: we use the alternative stack local variable W_est in cubic_ack_received().
cwnd_prior: it is used for Reno-Friendly Region in RFC9438 Section 4.3, but we use the alternative cwnd from NewReno for Reno-Friendly as in commit ee45061051715be4704ba22d2fcd1c373e29079d.

No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cc created this revision.Fri, Feb 14, 4:15 PM

Herald added a reviewer: transport. · View Herald TranscriptFri, Feb 14, 4:15 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript

cc requested review of this revision.Fri, Feb 14, 4:15 PM

Harbormaster completed remote builds in B62448: Diff 151042.Fri, Feb 14, 4:15 PM

cc edited the summary of this revision. (Show Details)Fri, Feb 14, 4:19 PM

tuexen accepted this revision.Fri, Feb 14, 4:55 PM

This revision is now accepted and ready to land.Fri, Feb 14, 4:55 PM

rscheff accepted this revision.Thu, Feb 20, 3:17 PM

Closed by commit rG7f9ef5c75fd1: cc_cubic: remove redundant code (authored by cc). · Explain WhyThu, Feb 20, 4:01 PM

This revision was automatically updated to reflect the committed changes.

cc added a commit: rG7f9ef5c75fd1: cc_cubic: remove redundant code.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

cc/

10 lines

5 lines

Diff 151254

sys/netinet/cc/cc_cubic.h

Loading...

sys/netinet/cc/cc_cubic.c

Loading...