syslogd: Fix tests when if_epair is not loaded
ClosedPublic
Actions

Authored by jlduran on Feb 11 2025, 10:42 PM.

Details

Reviewers

emaste
markj

Commits

rG8d9c25c4e171: syslogd: Fix tests when if_epair is not loaded

Summary

Take a cue from vnet.subr and abstract module loading, jail creation and
cleanup.

Note that the way jails are created differs slightly from vnet.subr, to
maintain the current style of the tests.

Reported by: Jenkins

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jlduran created this revision.Feb 11 2025, 10:42 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 11 2025, 10:42 PM

jlduran requested review of this revision.Feb 11 2025, 10:42 PM

Harbormaster completed remote builds in B62376: Diff 150863.Feb 11 2025, 10:42 PM

markj added inline comments.Feb 12 2025, 2:06 PM

usr.sbin/syslogd/tests/syslogd_test_common.sh
140	Doesn't this mean we only pass the first optional argument to jail(8)?

Address suggestions:

Accept all arguments (not just the first one) after the jail name

Harbormaster completed remote builds in B62394: Diff 150904.Feb 12 2025, 2:16 PM

Thank you very much.

This revision is now accepted and ready to land.Feb 12 2025, 2:18 PM

Closed by commit rG8d9c25c4e171: syslogd: Fix tests when if_epair is not loaded (authored by jlduran). · Explain WhyFeb 12 2025, 2:45 PM

This revision was automatically updated to reflect the committed changes.

jlduran added a commit: rG8d9c25c4e171: syslogd: Fix tests when if_epair is not loaded.

Revision Contents
Changeset List

Path

Size

usr.sbin/

syslogd/

tests/

syslogd_test.sh

23 lines

syslogd_test_common.sh

43 lines

Diff 150907

View Options

usr.sbin/syslogd/tests/syslogd_test.sh