samba: Fix comflict of PKGNAME, introduce new SAMBA_*_PORT variables

[yasu]

Summary

• Fix conflict of PKGNAME by adding PKGNAMESUFFIX to the ports below
  • databases/tdb1410
  • devel/talloc242
  • devel/tevent016
• Set CONFLICTS_INSTALL between different versions of each port.
• Update dependencies of databases/ldb29 and net/samba420 to reflect change of PKGNAME.
• Introduce 3 new variable, SAMBA_TALLOC_PORT, SAMBA_TDB_PORT and SAMBA_TEVENT_PORT. Proper port origin ("databases/ldb29" for example) is assigned to them depending on the value of SAMBA_DEFAULT. They are intended to be used by ports that works with Samba to specify proper version of talloc, tdb and/or tevent as dependency.
• Update some ports that work with Samba and depend on either of them so these variables are used in LIB_DEPENDS.
• Add item in CHANGES.

Note that there are some other ports that depends on either of talloc,
tdb or tevent. But they just use them as dependencies and have
nothing to do with Samba itself. So I keep them untouched.

Test Plan

Build of all modified ports succeeds with poudriere and 14.2-RELEASE amd64 jail exept www/squid.
As for www/squid, build fails in confiugre phase if TDB option is enabled.
But it also happnes with original one.
So it isn't fault of this change.

[yasu]

Bump PORTREVISION of modified ports.

[0mp]

The change is great and very much welcomed. Thank you for working on that.

Here is some feedback:

• There are some typos in the commit message.
• It would be better to split this change set into at least 3 different commits:
  1. The samba.mk changes.
  2. Fixes to PKGNAMEs
  3. Updates to consumers of USES=samba

CHANGES

16 ↗

(On Diff #150447)

Everything should be indented with 2 spaces.

22 ↗

(On Diff #150447)

26 ↗

(On Diff #150447)

26 ↗

(On Diff #150447)

Style suggestion: Code blocks are usually indented with 4 extra spaces (so 6 in total) instead of being delimited with ----------------------------------------------------------------------.

Mk/Uses/samba.mk

34 ↗

(On Diff #150447)

Note: I prefer the previous style as you can clearly see all the final assignments in one code block. Also, for example if needed, a user may depend on a version of ldb of a different Samba version. If there is a good reason to switch to the if statements it's ok, but I'm not a big fan of that.

databases/tdb/Makefile

3

Broken indentation.

databases/tdb1410/Makefile

3

Broken indentation.

devel/talloc/Makefile

3

Broken indentation.

devel/talloc242/Makefile

3

Broken indentation.

devel/tevent/Makefile

3

Broken indentation.

devel/tevent016/Makefile

3

Broken indentation.

net/freeradius3/Makefile

154 ↗

(On Diff #150447)

These could probably become SAMBA_INCLUDEDIR and SAMBA_LIBDIR while here.

www/squid/Makefile

3 ↗

(On Diff #150447)

If the build failed when the TDB option was enabled and also the TDB option is not default, maybe it does not make sense to bump the port revision here. The package won't change for downstream pkg consumers as Samba 4.16 is still the default, so maybe there is no need to force the regeneration of packages. Just a thought.

261 ↗

(On Diff #150447)

Wouldn't the following work?

AUTH_SMB_USES=			samba:run
TDB_USES=                       samba:env

[yasu]

Split original change set into 3 commit and update to the one that fixes conflict of PKGNAME.
Other 2 commits will be submitted as new review.

[yasu]

Fix indentation of PORTREVISION.

[0mp]

Thank you!

Reviewed by: 0mp
Approved by: samba (0mp)

[kiwi]

Since 0mp approved I Approve as well