Paths

Table of Contentst

Differential D48762

linuxkpi: Don't destroy the mutex in `xa_destroy()`
ClosedPublic
Actions

Authored by dumbbell on Fri, Jan 31, 2:29 PM.

Tags

None

Referenced Files

	F109318339: D48762.id150283.diff
	Mon, Feb 3, 12:33 PM

	Unknown Object (File)
	Fri, Jan 31, 9:12 PM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rGe5764cf07588: linuxkpi: Don't destroy the mutex in `xa_destroy()`

Summary

Why

The mutex initialized in xa_init_flags() is not destroyed here on purpose. The reason is that on Linux, the xarray remains usable after a call to xa_destroy(). For instance the i915 DRM driver relies on that during the initialixation of its GuC. Basically, xa_destroy() "resets" the structure to zero but doesn't really destroy it.

This is part of the update of DRM drivers to Linux 6.7.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dumbbell created this revision.Fri, Jan 31, 2:29 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptFri, Jan 31, 2:29 PM

dumbbell requested review of this revision.Fri, Jan 31, 2:29 PM

manu accepted this revision.Fri, Jan 31, 2:42 PM

This revision is now accepted and ready to land.Fri, Jan 31, 2:42 PM

Closed by commit rGe5764cf07588: linuxkpi: Don't destroy the mutex in `xa_destroy()` (authored by dumbbell). · Explain WhyFri, Jan 31, 4:04 PM

This revision was automatically updated to reflect the committed changes.

dumbbell added a commit: rGe5764cf07588: linuxkpi: Don't destroy the mutex in `xa_destroy()`.

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

src/

12 lines

Diff 150283

sys/compat/linuxkpi/common/src/linux_xarray.c

Loading...