mixer(3): Do not skip devices with no volume control
ClosedPublic
Actions

Authored by christos on Jan 30 2025, 5:57 PM.

Details

Reviewers

markj
emaste
dev_submerge.ch

Commits

rG311b84540e73: mixer(3): Do not skip devices with no volume control
rGf121de8fbcbc: mixer(3): Do not skip devices with no volume control

Summary

Some devices might not have a software volume control, but still be
able to be set as recording sources.

PR: 279787
Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Jan 30 2025, 5:57 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 30 2025, 5:57 PM

christos requested review of this revision.Jan 30 2025, 5:57 PM

Harbormaster completed remote builds in B62151: Diff 150209.Jan 30 2025, 5:57 PM

christos retitled this revision from mixer(3): Do not skip recording-only devices to mixer(3): Do not skip devices with no volume control.Feb 1 2025, 11:08 AM

christos edited the summary of this revision. (Show Details)

Related discussion in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279787. The issue is solved with this patch.

Thanks for updating the title, I was confused by this originally

lib/libmixer/mixer.c
124	Probably worth a comment here explaining why we allow failure. Or maybe `if (_mixer_readvol(dp) < 0 && MIX_ISDEV(m, i))`?

This revision is now accepted and ready to land.Feb 3 2025, 12:21 PM

Address Ed's comment.

This revision now requires review to proceed.Feb 3 2025, 1:25 PM

Harbormaster completed remote builds in B62220: Diff 150404.Feb 3 2025, 1:25 PM

Ah yes, that's even better

This revision is now accepted and ready to land.Feb 3 2025, 2:47 PM

Closed by commit rGf121de8fbcbc: mixer(3): Do not skip devices with no volume control (authored by christos). · Explain WhyFeb 25 2025, 11:49 AM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rGf121de8fbcbc: mixer(3): Do not skip devices with no volume control.

christos added a commit: rG311b84540e73: mixer(3): Do not skip devices with no volume control.Tue, Mar 4, 3:47 PM

Revision Contents
Changeset List

Path

Size

lib/

libmixer/

mixer.c

4 lines

Diff 151473

View Options

mixer(3): Do not skip devices with no volume controlClosedPublicActions