Page MenuHomeFreeBSD

rtw88: try to see if this is the skb leak
AbandonedPublic

Authored by bz on Jan 15 2025, 10:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 14, 2:02 PM
Unknown Object (File)
Sat, Mar 8, 12:43 AM
Unknown Object (File)
Tue, Mar 4, 12:09 PM
Unknown Object (File)
Feb 2 2025, 5:56 PM
Unknown Object (File)
Jan 30 2025, 2:14 PM
Unknown Object (File)
Jan 26 2025, 7:07 PM
Unknown Object (File)
Jan 21 2025, 7:00 AM
Unknown Object (File)
Jan 20 2025, 5:54 PM

Details

Reviewers
None
Summary

The tx_report purge_timer has been a souce of massive logging at times
in the past so it is the best shot in the dark for an endless queuing
of skbs. That would happen if more and more reports come in and the
timer gets pushed further and further and never expires and at the same
time the information is not picked up by rtw_tx_report_handle().

Add a WARN_ONCE to __skb_queue_purge() just to make sure there is no
glitch due to missing locking.

Also add a rolling error reporting for skb allocation failures in
LinuxKPI to gather some more information if possible about queue
states. In the rtw88 case when everything grinds to a halt this will
likely need kern.msgbufsize=1146880 (or 4M) in loader.conf to allow
bringing down wlan0 in time before all information from the beginning
scrolls away.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week
X-MFC: first needs to show to help

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 61745
Build 58629: arc lint + arc unit