www/py-homeassistant: Open-source home automation plateform Open source home automation that puts local control and privacy first. Powered by a worldwide community of tinkerers and DIY enthusiasts. Perfect to run on a Raspberry Pi or a local server. PR: 256885 Approved by: 0mp (mentor) Co-authored-by: kiwi
Details
- Reviewers
0mp
- portlinted / portclippied
- build with poudriere on 14.1 and 14.2
- tested on FreeBSD 14.2 jail and starting sucessfully
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
It would be good to ask on the -ports mailing list about some extra review. Installing software via Python virtual environments is unprecedented in the ports tree I think. Or at least not well established. That is why additional review would be beneficial.
www/py-homeassistant/Makefile | ||
---|---|---|
63 | Is it necessary? From what I understand, we do fetch anything and do not build anything, so where do all the staged files come from? If that's not too much work, you could upload a copy of the ${TMPPLIST} file somewhere and then we can take a look. | |
www/py-homeassistant/files/home-assistant.in | ||
26 | Could this be done with nproc? It's available on all supported releases. | |
27 | /usr/local here should be %%LOCALBASE%% Also, it'd help if you could add newlines in between the environment variables | |
66 | Please use info or debug instead of echo for messages like that. | |
www/py-homeassistant/pkg-message | ||
5 | Unnecessary newline. | |
6 | What does that mean? Is there some link explaining that? | |
17 |
www/py-homeassistant/pkg-message | ||
---|---|---|
6 | Home Assistant have several part :
... |