Page MenuHomeFreeBSD

[NEW-PORT] www/py-homeassistant: Open-source home automation plateform
Needs RevisionPublic

Authored by kiwi on Tue, Jan 14, 8:31 PM.
Tags
None
Referenced Files
F107998040: D48458.diff
Mon, Jan 20, 8:53 AM
F107965119: D48458.id149296.diff
Mon, Jan 20, 12:54 AM
F107918820: D48458.id149261.diff
Sun, Jan 19, 10:27 AM
Unknown Object (File)
Sun, Jan 19, 8:09 AM
Unknown Object (File)
Sat, Jan 18, 10:23 PM
Unknown Object (File)
Sat, Jan 18, 8:12 PM
Unknown Object (File)
Sat, Jan 18, 8:12 PM
Unknown Object (File)
Sat, Jan 18, 8:12 PM
Subscribers
None

Details

Reviewers
0mp
Summary
www/py-homeassistant: Open-source home automation plateform

Open source home automation that puts local control and privacy first.
Powered by a worldwide community of tinkerers and DIY enthusiasts.
Perfect to run on a Raspberry Pi or a local server.

PR:     256885
Approved by:    0mp (mentor)
Co-authored-by: kiwi
Test Plan
  • portlinted / portclippied
  • build with poudriere on 14.1 and 14.2
  • tested on FreeBSD 14.2 jail and starting sucessfully

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kiwi requested review of this revision.Tue, Jan 14, 8:31 PM
kiwi created this revision.

Removed PORTREVISION used for my own poudriere

BTW, did you develop this patch yourself or is it someone's work from the PR?

Used the port from the bugzilla and fixed few things.

Added co-author and fixed author of the patch on the git commit

It would be good to ask on the -ports mailing list about some extra review. Installing software via Python virtual environments is unprecedented in the ports tree I think. Or at least not well established. That is why additional review would be beneficial.

www/py-homeassistant/Makefile
63

Is it necessary? From what I understand, we do fetch anything and do not build anything, so where do all the staged files come from?

If that's not too much work, you could upload a copy of the ${TMPPLIST} file somewhere and then we can take a look.

www/py-homeassistant/files/home-assistant.in
26

Could this be done with nproc? It's available on all supported releases.

27

/usr/local here should be %%LOCALBASE%%

Also, it'd help if you could add newlines in between the environment variables

66

Please use info or debug instead of echo for messages like that.

www/py-homeassistant/pkg-message
5

Unnecessary newline.

6

What does that mean? Is there some link explaining that?

17
0mp requested changes to this revision.Fri, Jan 17, 11:17 AM
This revision now requires changes to proceed.Fri, Jan 17, 11:17 AM
kiwi marked an inline comment as done.Fri, Jan 17, 7:48 PM
kiwi added inline comments.
www/py-homeassistant/pkg-message
6

Home Assistant have several part :

  • Home Assistant Core (this port)
  • Home Assistant OS (TL:DR; Linux + docker + stuff to make it usable from Home Assistant Core)
  • Home Assistant Frontend (that will be installed into this venv)

...
All of them use Home Assistant Core to make them run.
For "easy usage", we don't add "Core"... but https://github.com/orgs/home-assistant/repositories can show all repos that can be installed thru this port (if compatible).