Page MenuHomeFreeBSD

Fix lib/libc/nss/getgr_test with large numbers of groups
ClosedPublic

Authored by asomers on Tue, Dec 31, 9:01 PM.
Tags
None
Referenced Files
F107296452: D48275.diff
Sun, Jan 12, 3:53 AM
Unknown Object (File)
Thu, Jan 9, 8:19 PM
Unknown Object (File)
Tue, Jan 7, 1:59 AM
Unknown Object (File)
Mon, Jan 6, 3:22 PM
Unknown Object (File)
Mon, Jan 6, 3:13 PM
Unknown Object (File)
Mon, Jan 6, 2:28 PM
Unknown Object (File)
Fri, Jan 3, 10:54 PM
Unknown Object (File)
Wed, Jan 1, 8:25 PM
Subscribers

Details

Summary

These tests create a linked list with one entry for every group on the
running system. On a system with about 30,000 groups, the test took 69
seconds to run, and crashed Kyua with the below error:

kyua: E: string or blob too big (sqlite op: sqlite3_bind_blob) (sqlite db: /root/.kyua/store/results.usr_tests.20241231-203317-570235.db).

Fix the test by limiting it to operating on the first 1024 groups.
Apply the same change to getpw_test and getserv_test too, which are
vulnerable to the same problem.

MFC after: 2 weeks
Sponsored by: ConnectWise

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable