Page MenuHomeFreeBSD
Differential D48146

[PATCH] net-mgmt/nagios: Add monplugins flavor
ClosedPublic
Actions

Authored by kiwi on Dec 19 2024, 12:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 30, 1:21 PM
Unknown Object (File)
Tue, Jan 28, 10:57 PM
Unknown Object (File)
Tue, Jan 28, 10:57 PM
Unknown Object (File)
Tue, Jan 28, 10:36 PM
Unknown Object (File)
Wed, Jan 8, 1:26 AM
Unknown Object (File)
Jan 1 2025, 1:05 AM
Unknown Object (File)
Dec 31 2024, 12:34 AM
Unknown Object (File)
Dec 30 2024, 12:36 AM
View All 14 Files
Subscribers
None

Details

Reviewers
0mp
joneum
Commits
R11:0fb561611ee8: net-mgmt/nagios: Add monplugins flavor
Summary
net-mgmt/nagios: Add monplugins flavor

Some users asked to add a flavor to permit to have nagios already
packaged with monplugins.

PR:    283977
Sponsored by:   Klara, Inc.
Approved by:    0mp (mentor)
Approved by:    joneum (maintainer)
Test Plan

Tested both flavors on poudriere on 13.4-RELEASE.
Portlinted and portclippied as well to check updated syntax are ok.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kiwi requested review of this revision.Dec 19 2024, 12:19 PM
kiwi created this revision.
0mp accepted this revision.Jan 6 2025, 1:51 PM

LGTM

I've got some suggestions for the commit message:

  • net-mgmt/nagios: Add monplugins flavor
  • There is no need to mention in the final commit message that this patch has been tested.

Also, please make sure to create a bugzilla ticket for this change. Not all maintainers check Phabricator.

This revision is now accepted and ready to land.Jan 6 2025, 1:51 PM
kiwi edited the summary of this revision. (Show Details)Fri, Jan 10, 10:27 AM
kiwi retitled this revision from [PATCH] net-mgmt/nagios: Adding monplugins flavor to nagios to [PATCH] net-mgmt/nagios: Add monplugins flavor.
kiwi edited the summary of this revision. (Show Details)
kiwi edited the test plan for this revision. (Show Details)
0mp added a comment.Fri, Jan 10, 12:39 PM

Cool, thanks for the updates. Let's wait for @joneum.

joneum accepted this revision.Tue, Jan 28, 9:55 PM

LGTM :-)

0mp requested changes to this revision.Wed, Jan 29, 10:14 AM

Cool, please update the commit message with the entertainer's approval. I'll review it and then accept the revision.

This revision now requires changes to proceed.Wed, Jan 29, 10:14 AM
kiwi updated this revision to Diff 150101.Wed, Jan 29, 3:37 PM
kiwi edited the summary of this revision. (Show Details)

Added Approved by: joneum (maintainer) in commit message

0mp accepted this revision.Thu, Jan 30, 10:18 AM

Thank you! Approved!

This revision is now accepted and ready to land.Thu, Jan 30, 10:18 AM
Closed by commit R11:0fb561611ee8: net-mgmt/nagios: Add monplugins flavor (authored by kiwi). · Explain WhyThu, Jan 30, 12:51 PM
This revision was automatically updated to reflect the committed changes.
kiwi added a commit: R11:0fb561611ee8: net-mgmt/nagios: Add monplugins flavor.

Revision Contents
Changeset List

PathSize
net-mgmt/
nagios/
13 lines

Diff 150179

View Options

net-mgmt/nagios/Makefile

Loading...