Page MenuHomeFreeBSD
Differential D48070

libprocstat: ZFS support: Makefile: Tidy up a bit
ClosedPublic
Actions

Authored by olce on Dec 13 2024, 10:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 21, 11:50 AM
Unknown Object (File)
Dec 19 2024, 11:39 PM
Unknown Object (File)
Dec 19 2024, 6:26 PM
Subscribers
delphij
imp

Details

Reviewers
emaste
kevans
Commits
rG6f43ca650d64: libprocstat: ZFS support: Makefile: Tidy up a bit
rG76d0aed16439: libprocstat: ZFS support: Makefile: Tidy up a bit
rG618c97b87b71: libprocstat: ZFS support: Makefile: Tidy up a bit
Summary

Regroup assignments tweaking preprocessor defines/undefs, and separately
those about include directories.

Re-order include directories a bit more logically, and remove redundant
ones.

Separate logical groups by blank lines.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olce created this revision.Dec 13 2024, 10:20 AM
Herald added subscribers: delphij, imp. · View Herald TranscriptDec 13 2024, 10:20 AM
olce requested review of this revision.Dec 13 2024, 10:20 AM
Harbormaster completed remote builds in B61141: Diff 147916.Dec 13 2024, 10:20 AM
olce added reviewers: emaste, kevans.Dec 13 2024, 10:21 AM
emaste added a comment.Dec 13 2024, 2:29 PM

This seems logical to me. One suggestion - it would be great to build with and without this change, confirm that the built artifacts are identical, and mention that in the commit message.

lib/libprocstat/zfs/Makefile
23–24

These are all just providing a somewhat-kernel-compatible #define environment, yeah? Might be worth a comment to that effect.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 19 2024, 10:37 PM
Closed by commit rG618c97b87b71: libprocstat: ZFS support: Makefile: Tidy up a bit (authored by olce). · Explain Why
This revision was automatically updated to reflect the committed changes.
olce added a commit: rG618c97b87b71: libprocstat: ZFS support: Makefile: Tidy up a bit.
olce added a commit: rG76d0aed16439: libprocstat: ZFS support: Makefile: Tidy up a bit.Thu, Jan 16, 6:09 PM
olce added a commit: rG6f43ca650d64: libprocstat: ZFS support: Makefile: Tidy up a bit.Fri, Jan 17, 12:28 PM

Revision Contents
Changeset List

PathSize
lib/
libprocstat/
zfs/
18 lines

Diff 148262

View Options

lib/libprocstat/zfs/Makefile

Loading...