Page MenuHomeFreeBSD

linuxkpi: Fix a lock leak in lkpi_sta_scan_to_auth()
ClosedPublic

Authored by markj on Dec 6 2024, 9:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 6, 3:17 PM
Unknown Object (File)
Mon, Feb 24, 10:18 AM
Unknown Object (File)
Feb 12 2025, 9:11 AM
Unknown Object (File)
Feb 12 2025, 9:10 AM
Unknown Object (File)
Feb 12 2025, 9:05 AM
Unknown Object (File)
Feb 12 2025, 5:49 AM
Unknown Object (File)
Jan 30 2025, 8:49 AM
Unknown Object (File)
Jan 5 2025, 8:01 AM

Details

Summary

PR: 283015
Fixes: 0936c648ad0e ("LinuxKPI: 802.11: update the ni/lsta reference cycle")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Dec 6 2024, 9:33 PM
sys/compat/linuxkpi/common/src/linux_80211.c
1190

what is the lock lifecycle of this one?

Plug a reference count leak as well.

markj marked an inline comment as done.Dec 6 2024, 9:59 PM
markj added inline comments.
sys/compat/linuxkpi/common/src/linux_80211.c
1190

I believe the caller is expected to lock it. This function re-acquires the lock further below. I did miss a refcount leak though.

This revision is now accepted and ready to land.Dec 7 2024, 1:42 AM
This revision was automatically updated to reflect the committed changes.
markj marked an inline comment as done.