Page MenuHomeFreeBSD

git-arc: fix diff2reviewers() with multiple reviewers
ClosedPublic

Authored by glebius on Dec 3 2024, 8:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 25, 2:01 AM
Unknown Object (File)
Mon, Apr 14, 2:12 AM
Unknown Object (File)
Sat, Apr 5, 10:34 PM
Unknown Object (File)
Mar 23 2025, 4:01 PM
Unknown Object (File)
Mar 20 2025, 7:23 AM
Unknown Object (File)
Mar 20 2025, 7:22 AM
Unknown Object (File)
Mar 19 2025, 11:58 PM
Unknown Object (File)
Feb 19 2025, 1:10 PM
Subscribers

Details

Summary

The select command of jq provides us with a multiline output. Thus, the
${userids} is a newline separated list. The recent change 9e84289f2c7e
explicitly said that we aren't going to translate newline to comma when
constructing JSON for the next command. It also forces the ${userids} to
be printed as is, with shell's field splitting disabled. So we end up
with invalid JSON, that is missing commas.

Fix this by enabling shell's field splitting by printing ${userids}
outside of double quotes.

Fixes: 9e84289f2c7e6b632047a75b653fcd587287a8b9

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable