Page MenuHomeFreeBSD

git-arc: fix diff2reviewers() with multiple reviewers
ClosedPublic

Authored by glebius on Dec 3 2024, 8:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 19, 1:10 PM
Unknown Object (File)
Tue, Feb 18, 11:31 AM
Unknown Object (File)
Feb 4 2025, 2:44 PM
Unknown Object (File)
Feb 3 2025, 1:05 PM
Unknown Object (File)
Dec 15 2024, 5:23 PM
Unknown Object (File)
Dec 6 2024, 12:36 PM
Unknown Object (File)
Dec 4 2024, 4:14 AM
Unknown Object (File)
Dec 4 2024, 2:39 AM
Subscribers

Details

Summary

The select command of jq provides us with a multiline output. Thus, the
${userids} is a newline separated list. The recent change 9e84289f2c7e
explicitly said that we aren't going to translate newline to comma when
constructing JSON for the next command. It also forces the ${userids} to
be printed as is, with shell's field splitting disabled. So we end up
with invalid JSON, that is missing commas.

Fix this by enabling shell's field splitting by printing ${userids}
outside of double quotes.

Fixes: 9e84289f2c7e6b632047a75b653fcd587287a8b9

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable